squakez commented on code in PR #5419: URL: https://github.com/apache/camel-k/pull/5419#discussion_r1579119631
########## pkg/trait/knative_service.go: ########## @@ -149,6 +150,11 @@ func (t *knativeServiceTrait) SelectControllerStrategy(e *Environment) (*Control return nil, nil } + // Knative serving is required + if ok, _ := knative.IsServingInstalled(e.Client); !ok { Review Comment: I missed this. We must move this into the `Configure()` func instead and add the related condition and report accordingly in order to warn the user that the trait is skipped because there is no serving API installed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org