squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580620317
########## pkg/apis/camel/v1/trait/dependencies.go: ########## @@ -20,7 +20,8 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal Review Comment: I think `lint` will complain as expects comments to end with a dot. Just `make lint` to verify. ########## docs/modules/ROOT/partials/apis/camel-k-crds.adoc: ########## @@ -8240,8 +8240,6 @@ Deprecated: for backward compatibility. * <<#_camel_apache_org_v1_IntegrationKitTraits, IntegrationKitTraits>> * <<#_camel_apache_org_v1_Traits, Traits>> -WARNING: The Registry trait is **deprecated** and will removed in future release versions. Review Comment: We can probably keep both image and description message, I don't think they are incompatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
