lburgazzoli commented on PR #5480: URL: https://github.com/apache/camel-k/pull/5480#issuecomment-2102204220
> > The failing test is marked a problematic and fails for a slightly different metric values: > > https://github.com/apache/camel-k/blob/4114271b6ccbc74e52a87455123fb522bbbf84a1/e2e/advanced/operator_metrics_test.go#L48-L55 > > > > I've created a follow up issue #5483 > > Please, don't rely on those marked as problematic. For some reason they were marked like that in order to identify certain problems happening on Openshift only. In github actions they should run correctly. If some failure is happening it could really because of the changes in the PR, given that we're changing the way to log build output. I've restarted the check, if it clears, then feel free to merge. If not, please, have a look at how the code change is affecting the expected behavior. Thanks. The PR does not change anything in how things are logged as the change is a cosmetic change to make the code more idiomatic. The same problem has happened in another PR with a completely different change so I guess the flakiness was something not environment specific but for some reason was easier to trigger on OpenShift rather than on minkube. Also, given that restarting the test did solve the issue for that particular test but triggered a new failure in another test (previously not failing), then it is a clear indication that this is not because of the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
