rolandaskozakas commented on code in PR #13491:
URL: https://github.com/apache/camel/pull/13491#discussion_r1599555046
##########
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##########
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
- // noop
+ if (redisConfiguration == null) {
Review Comment:
hello @davsclaus ,
After updating 4.4-4.5 this part seems to be failing.
Could you help me understand how this redisConfiguration should be
initialized here?
Because in my case it is just null which basically initializes redisTemplate
to default values.
What i am doing is:
```
@Bean
public SpringRedisStringIdempotentRepository
idempotentRepository(RedisTemplate<String, String> redisTemplate) {
SpringRedisStringIdempotentRepository idempotentRepository = new
SpringRedisStringIdempotentRepository(redisTemplate, IDEMPOTENT_REPOSITORY_KEY);
idempotentRepository.setExpiry(10000L);
return idempotentRepository;
}
```
Feedback appreciated!
##########
components/camel-spring-redis/src/main/java/org/apache/camel/component/redis/processor/idempotent/SpringRedisIdempotentRepository.java:
##########
@@ -95,7 +107,12 @@ public boolean confirm(String key) {
@Override
protected void doStart() throws Exception {
- // noop
+ if (redisConfiguration == null) {
Review Comment:
hello @davsclaus ,
After updating 4.4->4.5 this part seems to be failing.
Could you help me understand how this redisConfiguration should be
initialized here?
Because in my case it is just null which basically initializes redisTemplate
to default values.
What i am doing is:
```
@Bean
public SpringRedisStringIdempotentRepository
idempotentRepository(RedisTemplate<String, String> redisTemplate) {
SpringRedisStringIdempotentRepository idempotentRepository = new
SpringRedisStringIdempotentRepository(redisTemplate, IDEMPOTENT_REPOSITORY_KEY);
idempotentRepository.setExpiry(10000L);
return idempotentRepository;
}
```
Feedback appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
