valdar commented on code in PR #5503:
URL: https://github.com/apache/camel-k/pull/5503#discussion_r1603104066
##########
e2e/common/traits/health_test.go:
##########
@@ -363,9 +362,7 @@ func TestHealthTrait(t *testing.T) {
name := RandomizedSuffixName("never-ready")
g.Expect(KamelRunWithID(t, ctx, operatorID, ns,
"files/NeverReady.java", "--name", name, "-t", "health.enabled=true",
- // TODO remove these workaround properties when
https://issues.apache.org/jira/browse/CAMEL-20244 is fixed
- "-p",
"camel.route-controller.unhealthyOnRestarting=true",
- "-p",
"camel.route-controller.unhealthyOnExhausted=true",
+ "-p", "camel.health.routesEnabled=false",
Review Comment:
That is there to avoid any possible (present or future) interaction and side
effect between the custom check we define in files/NeverReady.java and the
default checks. At the moment the test makes sense and would work both with and
without that property, there are no routes declared in files/NeverReady.java
anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
