lburgazzoli commented on code in PR #14222:
URL: https://github.com/apache/camel/pull/14222#discussion_r1609599223
##########
core/camel-core-processor/src/main/java/org/apache/camel/processor/resequencer/ResequencerEngine.java:
##########
@@ -110,6 +120,30 @@ public synchronized int size() {
return sequence.size();
}
+ public void waitUntil(Predicate<Sequence<?>> pred) throws
InterruptedException {
+ CountDownLatch latch;
+ synchronized (this) {
Review Comment:
I don't know if applicable but a common patter is to have a _lock_ instance
and lock on that
```java
private final Object lock = new Object()
public void waitUntil(Predicate<Sequence<?>> pred) throws
InterruptedException {
synchronized(lock) { ... }
}
```
but this is really a nitpick, so as you explained the issue may be also
happen somewhere else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
