squakez commented on PR #97:
URL: https://github.com/apache/camel-k-examples/pull/97#issuecomment-2126419663

   > This 
[commit](https://github.com/apache/camel-k/commit/7ee129afcd7ee53b4f25f5dab1ecc55689b1f2cd)
 removes `resource-file-xyz.groovy` route definitions without providing yaml 
equivalents. This was because none of the tests referenced those groovy files. 
Perhaps the examples provide close enough testing templates to resurrect 
`resource-file` testing.
   > 
   > We don't have `--resource file:*` (any more), only `--resource 
configmap:*` and `--resource secret:*`
   
   We don't need to have parity between tests and examples. Examples are 
typically more oriented to show basic or complex use cases for users. I think 
in this case we do need to convert the binary and base64 from groovy to yaml 
and moving also from file to configmap (if no other similar example is already 
available, of course) as it is a useful demo scenario to show.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to