oscerd commented on code in PR #14274:
URL: https://github.com/apache/camel/pull/14274#discussion_r1618639161
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Endpoint.java:
##########
@@ -64,6 +63,30 @@ public AWS2S3Endpoint(String uri, Component comp,
AWS2S3Configuration configurat
this.configuration = configuration;
}
+ @Override
+ public String getServiceUrl() {
+ if (!configuration.isOverrideEndpoint()) {
+ return configuration.getBucketName() + "." + getServiceProtocol()
+ ".amazonaws.com";
Review Comment:
> is it bucketname or would it be something like region instead ?
It's bucket name, the region is not really important in this case and by way
the URL is purely an information, if it's public you can ping it, but if it's
private you'll get an access denied.
##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Endpoint.java:
##########
@@ -64,6 +63,30 @@ public AWS2S3Endpoint(String uri, Component comp,
AWS2S3Configuration configurat
this.configuration = configuration;
}
+ @Override
+ public String getServiceUrl() {
+ if (!configuration.isOverrideEndpoint()) {
+ return configuration.getBucketName() + "." + getServiceProtocol()
+ ".amazonaws.com";
Review Comment:
Also we could look at
https://community.aws/content/2biM1C0TkMkvJ2BLICiff8MKXS9/format-and-parse-amazon-s3-url
We have an option for path style, so we could form the URL based on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
