tdiesler commented on code in PR #5639:
URL: https://github.com/apache/camel-k/pull/5639#discussion_r1642549741


##########
e2e/advanced/environment_test.go:
##########
@@ -39,7 +40,58 @@ import (
        "github.com/apache/camel-k/v2/pkg/util/defaults"
 )
 
-func TestEnvironmentTrait(t *testing.T) {
+func TestEnvironmentTraitVars(t *testing.T) {
+       t.Parallel()
+
+       WithNewTestNamespace(t, func(ctx context.Context, g *WithT, ns string) {
+               operatorID := "camel-k-trait-environment"
+               g.Expect(CopyCamelCatalog(t, ctx, ns, operatorID)).To(Succeed())
+               g.Expect(CopyIntegrationKits(t, ctx, ns, 
operatorID)).To(Succeed())
+               g.Expect(KamelInstallWithID(t, ctx, operatorID, 
ns)).To(Succeed())
+
+               g.Eventually(SelectedPlatformPhase(t, ctx, ns, operatorID), 
TestTimeoutMedium).Should(Equal(v1.IntegrationPlatformPhaseReady))
+
+               // Create configmap
+               var cmData = make(map[string]string)
+               cmData["my-cm-key"] = "hello configmap"
+               err := CreatePlainTextConfigmap(t, ctx, ns, "my-cm", cmData)
+               require.NoError(t, err)

Review Comment:
   done



##########
e2e/advanced/environment_test.go:
##########
@@ -39,7 +40,58 @@ import (
        "github.com/apache/camel-k/v2/pkg/util/defaults"
 )
 
-func TestEnvironmentTrait(t *testing.T) {
+func TestEnvironmentTraitVars(t *testing.T) {
+       t.Parallel()
+
+       WithNewTestNamespace(t, func(ctx context.Context, g *WithT, ns string) {
+               operatorID := "camel-k-trait-environment"
+               g.Expect(CopyCamelCatalog(t, ctx, ns, operatorID)).To(Succeed())
+               g.Expect(CopyIntegrationKits(t, ctx, ns, 
operatorID)).To(Succeed())
+               g.Expect(KamelInstallWithID(t, ctx, operatorID, 
ns)).To(Succeed())
+
+               g.Eventually(SelectedPlatformPhase(t, ctx, ns, operatorID), 
TestTimeoutMedium).Should(Equal(v1.IntegrationPlatformPhaseReady))
+
+               // Create configmap
+               var cmData = make(map[string]string)
+               cmData["my-cm-key"] = "hello configmap"
+               err := CreatePlainTextConfigmap(t, ctx, ns, "my-cm", cmData)
+               require.NoError(t, err)
+
+               // Create secret
+               var secData = make(map[string]string)
+               secData["my-sec-key"] = "very top secret"
+               err = CreatePlainTextSecret(t, ctx, ns, "my-sec", secData)
+               require.NoError(t, err)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to