davsclaus commented on PR #14768: URL: https://github.com/apache/camel/pull/14768#issuecomment-2219737159
> > > I've left some suggestions. I think this is adding a lot of complexity to a component that is already very complex. IMHO, a decorator would be able to isolate that complexity and reduce the performance impacts on the hot path. > > > > > > The dev consoles are basic string and json object - its pure easy code - overkill to have template language as it adds unwanted dependency on some library. The dev consoles are used during development > > OK. > > > ... and not any hot-path at all. > > Actually, the code is indeed right in the hot path of the consumer, as it's within the loop that calls `poll`. That's my main concern with this change. Only doing the boolean check if dev-console is enabled now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
