This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
The following commit(s) were added to refs/heads/main by this push:
new b6bcb2bc4 fix(trait): add size to emptydir
b6bcb2bc4 is described below
commit b6bcb2bc462f2b085bde00bf0ddb85d3a735a6a7
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Thu Sep 5 17:30:42 2024 +0200
fix(trait): add size to emptydir
It is good to have a limit for security reasons and it is also a workaround
for #5752
Closes #5752
---
pkg/trait/trait_types.go | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/pkg/trait/trait_types.go b/pkg/trait/trait_types.go
index 299b7f1c2..7a890af40 100644
--- a/pkg/trait/trait_types.go
+++ b/pkg/trait/trait_types.go
@@ -29,6 +29,7 @@ import (
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
+ "k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
serving "knative.dev/serving/pkg/apis/serving/v1"
@@ -595,7 +596,13 @@ func getVolume(volName, storageType, storageName,
filterKey, filterValue string)
ClaimName: storageName,
}
case emptyDirStorageType:
- volume.VolumeSource.EmptyDir = &corev1.EmptyDirVolumeSource{}
+ size, err := resource.ParseQuantity("1Gi")
+ if err != nil {
+ log.WithValues("Function",
"trait.getVolume").Errorf(err, "could not parse empty dir quantity, skipping")
+ }
+ volume.VolumeSource.EmptyDir = &corev1.EmptyDirVolumeSource{
+ SizeLimit: &size,
+ }
}
return &volume
