This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new eeab782e197 CAMEL-21183: camel-browse - Should keep all messages by
default as before
eeab782e197 is described below
commit eeab782e1978b2582baf6c376103f5fe5b905648
Author: Claus Ibsen <[email protected]>
AuthorDate: Tue Sep 10 11:39:11 2024 +0200
CAMEL-21183: camel-browse - Should keep all messages by default as before
---
.../org/apache/camel/catalog/components/browse.json | 5 +++--
.../component/browse/BrowseComponentConfigurer.java | 6 ++++++
.../org/apache/camel/component/browse/browse.json | 5 +++--
.../camel/component/browse/BrowseComponent.java | 19 ++++++++++++++-----
.../apache/camel/component/browse/BrowseEndpoint.java | 4 ++--
.../component/dsl/BrowseComponentBuilderFactory.java | 17 +++++++++++++++++
.../endpoint/dsl/BrowseEndpointBuilderFactory.java | 6 ------
7 files changed, 45 insertions(+), 17 deletions(-)
diff --git
a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/browse.json
b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/browse.json
index 86a14766553..65c33830c21 100644
---
a/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/browse.json
+++
b/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/browse.json
@@ -26,7 +26,8 @@
"componentProperties": {
"bridgeErrorHandler": { "index": 0, "kind": "property", "displayName":
"Bridge Error Handler", "group": "consumer", "label": "consumer", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": false, "description":
"Allows for bridging the consumer to the Camel routing Error Handler, which
mean any exceptions (if possible) occurred while the Camel consumer is trying
to pickup incoming messages, or the like [...]
"lazyStartProducer": { "index": 1, "kind": "property", "displayName":
"Lazy Start Producer", "group": "producer", "label": "producer", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": false, "description":
"Whether the producer should be started lazy (on the first message). By
starting lazy you can use this to allow CamelContext and routes to startup in
situations where a producer may otherwise fail [...]
- "autowiredEnabled": { "index": 2, "kind": "property", "displayName":
"Autowired Enabled", "group": "advanced", "label": "advanced", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": true, "description":
"Whether autowiring is enabled. This is used for automatic autowiring options
(the option must be marked as autowired) by looking up in the registry to find
if there is a single instance of matching t [...]
+ "autowiredEnabled": { "index": 2, "kind": "property", "displayName":
"Autowired Enabled", "group": "advanced", "label": "advanced", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": true, "description":
"Whether autowiring is enabled. This is used for automatic autowiring options
(the option must be marked as autowired) by looking up in the registry to find
if there is a single instance of matching t [...]
+ "browseLimit": { "index": 3, "kind": "property", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "description": "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited." }
},
"properties": {
"name": { "index": 0, "kind": "path", "displayName": "Name", "group":
"common", "label": "", "required": true, "type": "string", "javaType":
"java.lang.String", "deprecated": false, "deprecationNote": "", "autowired":
false, "secret": false, "description": "A name which can be any string to
uniquely identify the endpoint" },
@@ -34,7 +35,7 @@
"exceptionHandler": { "index": 2, "kind": "parameter", "displayName":
"Exception Handler", "group": "consumer (advanced)", "label":
"consumer,advanced", "required": false, "type": "object", "javaType":
"org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.",
"deprecated": false, "autowired": false, "secret": false, "description": "To
let the consumer use a custom ExceptionHandler. Notice if the option
bridgeErrorHandler is enabled then this option is not in use. By def [...]
"exchangePattern": { "index": 3, "kind": "parameter", "displayName":
"Exchange Pattern", "group": "consumer (advanced)", "label":
"consumer,advanced", "required": false, "type": "object", "javaType":
"org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ],
"deprecated": false, "autowired": false, "secret": false, "description": "Sets
the exchange pattern when the consumer creates an exchange." },
"lazyStartProducer": { "index": 4, "kind": "parameter", "displayName":
"Lazy Start Producer", "group": "producer (advanced)", "label":
"producer,advanced", "required": false, "type": "boolean", "javaType":
"boolean", "deprecated": false, "autowired": false, "secret": false,
"defaultValue": false, "description": "Whether the producer should be started
lazy (on the first message). By starting lazy you can use this to allow
CamelContext and routes to startup in situations where a produc [...]
- "browseLimit": { "index": 5, "kind": "parameter", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "defaultValue": 100, "description": "Maximum number of
messages to keep in memory available for browsing. Use 0 for unlimited." },
+ "browseLimit": { "index": 5, "kind": "parameter", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "description": "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited." },
"filter": { "index": 6, "kind": "parameter", "displayName": "Filter",
"group": "advanced", "label": "advanced", "required": false, "type": "object",
"javaType": "java.util.function.Predicate<org.apache.camel.Exchange>",
"deprecated": false, "autowired": false, "secret": false, "description": "To
use a predicate to filter whether to include the message for browsing. Return
true to include, false to exclude." }
}
}
diff --git
a/components/camel-browse/src/generated/java/org/apache/camel/component/browse/BrowseComponentConfigurer.java
b/components/camel-browse/src/generated/java/org/apache/camel/component/browse/BrowseComponentConfigurer.java
index 5069007f6d2..0149d28d11d 100644
---
a/components/camel-browse/src/generated/java/org/apache/camel/component/browse/BrowseComponentConfigurer.java
+++
b/components/camel-browse/src/generated/java/org/apache/camel/component/browse/BrowseComponentConfigurer.java
@@ -27,6 +27,8 @@ public class BrowseComponentConfigurer extends
PropertyConfigurerSupport impleme
case "autowiredEnabled":
target.setAutowiredEnabled(property(camelContext, boolean.class, value));
return true;
case "bridgeerrorhandler":
case "bridgeErrorHandler":
target.setBridgeErrorHandler(property(camelContext, boolean.class, value));
return true;
+ case "browselimit":
+ case "browseLimit": target.setBrowseLimit(property(camelContext,
int.class, value)); return true;
case "lazystartproducer":
case "lazyStartProducer":
target.setLazyStartProducer(property(camelContext, boolean.class, value));
return true;
default: return false;
@@ -40,6 +42,8 @@ public class BrowseComponentConfigurer extends
PropertyConfigurerSupport impleme
case "autowiredEnabled": return boolean.class;
case "bridgeerrorhandler":
case "bridgeErrorHandler": return boolean.class;
+ case "browselimit":
+ case "browseLimit": return int.class;
case "lazystartproducer":
case "lazyStartProducer": return boolean.class;
default: return null;
@@ -54,6 +58,8 @@ public class BrowseComponentConfigurer extends
PropertyConfigurerSupport impleme
case "autowiredEnabled": return target.isAutowiredEnabled();
case "bridgeerrorhandler":
case "bridgeErrorHandler": return target.isBridgeErrorHandler();
+ case "browselimit":
+ case "browseLimit": return target.getBrowseLimit();
case "lazystartproducer":
case "lazyStartProducer": return target.isLazyStartProducer();
default: return null;
diff --git
a/components/camel-browse/src/generated/resources/META-INF/org/apache/camel/component/browse/browse.json
b/components/camel-browse/src/generated/resources/META-INF/org/apache/camel/component/browse/browse.json
index 86a14766553..65c33830c21 100644
---
a/components/camel-browse/src/generated/resources/META-INF/org/apache/camel/component/browse/browse.json
+++
b/components/camel-browse/src/generated/resources/META-INF/org/apache/camel/component/browse/browse.json
@@ -26,7 +26,8 @@
"componentProperties": {
"bridgeErrorHandler": { "index": 0, "kind": "property", "displayName":
"Bridge Error Handler", "group": "consumer", "label": "consumer", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": false, "description":
"Allows for bridging the consumer to the Camel routing Error Handler, which
mean any exceptions (if possible) occurred while the Camel consumer is trying
to pickup incoming messages, or the like [...]
"lazyStartProducer": { "index": 1, "kind": "property", "displayName":
"Lazy Start Producer", "group": "producer", "label": "producer", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": false, "description":
"Whether the producer should be started lazy (on the first message). By
starting lazy you can use this to allow CamelContext and routes to startup in
situations where a producer may otherwise fail [...]
- "autowiredEnabled": { "index": 2, "kind": "property", "displayName":
"Autowired Enabled", "group": "advanced", "label": "advanced", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": true, "description":
"Whether autowiring is enabled. This is used for automatic autowiring options
(the option must be marked as autowired) by looking up in the registry to find
if there is a single instance of matching t [...]
+ "autowiredEnabled": { "index": 2, "kind": "property", "displayName":
"Autowired Enabled", "group": "advanced", "label": "advanced", "required":
false, "type": "boolean", "javaType": "boolean", "deprecated": false,
"autowired": false, "secret": false, "defaultValue": true, "description":
"Whether autowiring is enabled. This is used for automatic autowiring options
(the option must be marked as autowired) by looking up in the registry to find
if there is a single instance of matching t [...]
+ "browseLimit": { "index": 3, "kind": "property", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "description": "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited." }
},
"properties": {
"name": { "index": 0, "kind": "path", "displayName": "Name", "group":
"common", "label": "", "required": true, "type": "string", "javaType":
"java.lang.String", "deprecated": false, "deprecationNote": "", "autowired":
false, "secret": false, "description": "A name which can be any string to
uniquely identify the endpoint" },
@@ -34,7 +35,7 @@
"exceptionHandler": { "index": 2, "kind": "parameter", "displayName":
"Exception Handler", "group": "consumer (advanced)", "label":
"consumer,advanced", "required": false, "type": "object", "javaType":
"org.apache.camel.spi.ExceptionHandler", "optionalPrefix": "consumer.",
"deprecated": false, "autowired": false, "secret": false, "description": "To
let the consumer use a custom ExceptionHandler. Notice if the option
bridgeErrorHandler is enabled then this option is not in use. By def [...]
"exchangePattern": { "index": 3, "kind": "parameter", "displayName":
"Exchange Pattern", "group": "consumer (advanced)", "label":
"consumer,advanced", "required": false, "type": "object", "javaType":
"org.apache.camel.ExchangePattern", "enum": [ "InOnly", "InOut" ],
"deprecated": false, "autowired": false, "secret": false, "description": "Sets
the exchange pattern when the consumer creates an exchange." },
"lazyStartProducer": { "index": 4, "kind": "parameter", "displayName":
"Lazy Start Producer", "group": "producer (advanced)", "label":
"producer,advanced", "required": false, "type": "boolean", "javaType":
"boolean", "deprecated": false, "autowired": false, "secret": false,
"defaultValue": false, "description": "Whether the producer should be started
lazy (on the first message). By starting lazy you can use this to allow
CamelContext and routes to startup in situations where a produc [...]
- "browseLimit": { "index": 5, "kind": "parameter", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "defaultValue": 100, "description": "Maximum number of
messages to keep in memory available for browsing. Use 0 for unlimited." },
+ "browseLimit": { "index": 5, "kind": "parameter", "displayName": "Browse
Limit", "group": "advanced", "label": "advanced", "required": false, "type":
"integer", "javaType": "int", "deprecated": false, "autowired": false,
"secret": false, "description": "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited." },
"filter": { "index": 6, "kind": "parameter", "displayName": "Filter",
"group": "advanced", "label": "advanced", "required": false, "type": "object",
"javaType": "java.util.function.Predicate<org.apache.camel.Exchange>",
"deprecated": false, "autowired": false, "secret": false, "description": "To
use a predicate to filter whether to include the message for browsing. Return
true to include, false to exclude." }
}
}
diff --git
a/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseComponent.java
b/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseComponent.java
index c906e590811..c2489d9cae8 100644
---
a/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseComponent.java
+++
b/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseComponent.java
@@ -19,16 +19,16 @@ package org.apache.camel.component.browse;
import java.util.Map;
import org.apache.camel.Endpoint;
+import org.apache.camel.spi.Metadata;
import org.apache.camel.support.DefaultComponent;
-/**
- * The <a href="http://camel.apache.org/browse.html";>Browse Component</a>
provides a simple
- * <a
href="http://camel.apache.org/browsableendpoint.html";>BrowsableEndpoint</a> for
testing visualization or
- * debugging.
- */
@org.apache.camel.spi.annotations.Component("browse")
public class BrowseComponent extends DefaultComponent {
+ @Metadata(label = "advanced",
+ description = "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited.")
+ private int browseLimit;
+
public BrowseComponent() {
}
@@ -36,7 +36,16 @@ public class BrowseComponent extends DefaultComponent {
protected Endpoint createEndpoint(String uri, String remaining,
Map<String, Object> parameters) throws Exception {
BrowseEndpoint endpoint = new BrowseEndpoint(uri, this);
endpoint.setName(remaining);
+ endpoint.setBrowseLimit(browseLimit);
setProperties(endpoint, parameters);
return endpoint;
}
+
+ public int getBrowseLimit() {
+ return browseLimit;
+ }
+
+ public void setBrowseLimit(int browseLimit) {
+ this.browseLimit = browseLimit;
+ }
}
diff --git
a/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseEndpoint.java
b/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseEndpoint.java
index 9530d39638b..e6c657484c9 100644
---
a/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseEndpoint.java
+++
b/components/camel-browse/src/main/java/org/apache/camel/component/browse/BrowseEndpoint.java
@@ -48,9 +48,9 @@ public class BrowseEndpoint extends DefaultEndpoint
implements BrowsableEndpoint
@UriPath(description = "A name which can be any string to uniquely
identify the endpoint")
@Metadata(required = true)
private String name;
- @UriParam(label = "advanced", defaultValue = "100",
+ @UriParam(label = "advanced",
description = "Maximum number of messages to keep in memory
available for browsing. Use 0 for unlimited.")
- private int browseLimit = 100;
+ private int browseLimit;
@UriParam(label = "advanced",
description = "To use a predicate to filter whether to include
the message for browsing. Return true to include, false to exclude.")
private Predicate<Exchange> filter;
diff --git
a/dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/BrowseComponentBuilderFactory.java
b/dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/BrowseComponentBuilderFactory.java
index 5140250b6c7..3aa22313e1b 100644
---
a/dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/BrowseComponentBuilderFactory.java
+++
b/dsl/camel-componentdsl/src/generated/java/org/apache/camel/builder/component/dsl/BrowseComponentBuilderFactory.java
@@ -124,6 +124,22 @@ public interface BrowseComponentBuilderFactory {
doSetProperty("autowiredEnabled", autowiredEnabled);
return this;
}
+
+ /**
+ * Maximum number of messages to keep in memory available for browsing.
+ * Use 0 for unlimited.
+ *
+ * The option is a: <code>int</code> type.
+ *
+ * Group: advanced
+ *
+ * @param browseLimit the value to set
+ * @return the dsl builder
+ */
+ default BrowseComponentBuilder browseLimit(int browseLimit) {
+ doSetProperty("browseLimit", browseLimit);
+ return this;
+ }
}
class BrowseComponentBuilderImpl
@@ -142,6 +158,7 @@ public interface BrowseComponentBuilderFactory {
case "bridgeErrorHandler": ((BrowseComponent)
component).setBridgeErrorHandler((boolean) value); return true;
case "lazyStartProducer": ((BrowseComponent)
component).setLazyStartProducer((boolean) value); return true;
case "autowiredEnabled": ((BrowseComponent)
component).setAutowiredEnabled((boolean) value); return true;
+ case "browseLimit": ((BrowseComponent)
component).setBrowseLimit((int) value); return true;
default: return false;
}
}
diff --git
a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/BrowseEndpointBuilderFactory.java
b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/BrowseEndpointBuilderFactory.java
index 5b4efbed2d3..1a79cb256a0 100644
---
a/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/BrowseEndpointBuilderFactory.java
+++
b/dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/BrowseEndpointBuilderFactory.java
@@ -177,7 +177,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option is a: <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
@@ -193,7 +192,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option will be converted to a <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
@@ -309,7 +307,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option is a: <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
@@ -325,7 +322,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option will be converted to a <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
@@ -399,7 +395,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option is a: <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
@@ -415,7 +410,6 @@ public interface BrowseEndpointBuilderFactory {
*
* The option will be converted to a <code>int</code> type.
*
- * Default: 100
* Group: advanced
*
* @param browseLimit the value to set
