davsclaus commented on code in PR #15592:
URL: https://github.com/apache/camel/pull/15592#discussion_r1764505428
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesRun.java:
##########
@@ -424,7 +424,7 @@ private Integer buildProject(String workingDir) throws
IOException, InterruptedE
List<String> args = new ArrayList<>();
args.add(workingDir + mvnw);
- args.add("--quiet");
+ // args.add("--quiet");
Review Comment:
Was this a mistake to remove
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesRun.java:
##########
@@ -455,7 +455,7 @@ private Integer deployProject(String workingDir) throws
IOException, Interrupted
List<String> args = new ArrayList<>();
args.add(workingDir + mvnw);
- args.add("--quiet");
+ // args.add("--quiet");
Review Comment:
Was this a mistake to remove
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesRun.java:
##########
@@ -499,6 +497,7 @@ private Integer deployProject(String workingDir) throws
IOException, Interrupted
args.add("k8s:deploy");
}
+ printer().println(String.join(" ", args));
Review Comment:
The other commands does not print.
The jbang commands usually have a `--verbose` flag also. So maybe we should
use that to print more details or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
