jamesnetherton commented on code in PR #6778:
URL: https://github.com/apache/camel-quarkus/pull/6778#discussion_r1840249366
##########
extensions-support/httpclient5/deployment/src/main/java/org/apache/camel/quarkus/support/httpclient5/deployment/HttpClient5Processor.java:
##########
@@ -34,4 +46,54 @@ NativeImageResourceBuildItem suffixListResource() {
void
runtimeInitializedClasses(BuildProducer<RuntimeInitializedClassBuildItem>
runtimeInitializedClasses) {
runtimeInitializedClasses.produce(new
RuntimeInitializedClassBuildItem(NTLM_ENGINE_IMPL));
}
+
+ @BuildStep(onlyIf = { NativeOrNativeSourcesBuild.class,
BrotliAbsentBooleanSupplier.class })
+ void generateBrotliInputStreamClass(BuildProducer<GeneratedClassBuildItem>
generatedClass) {
Review Comment:
> If there is something change with brotli in the future, this class name
maybe change or whatever. We have to rewrite it?
Yes, potentially. But the native compilation would probably fail if the
class got renamed. Aside from that it's just a implementation of `InputStream`
and we only need to override `read` to satisfy native compilation.
Also, there have been no new releases of brotli dec since 0.1.2 from May
2017. So it is maybe unlikely to change any time soon.
> GraalVM will do something with this optional deps
Yes, true. When that comes we can revisit all of these hacks that we have
for optional dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
