orpiske commented on code in PR #16773:
URL: https://github.com/apache/camel/pull/16773#discussion_r1910308825
##########
test-infra/camel-test-infra-ftp/src/main/java/org/apache/camel/test/infra/ftp/services/embedded/FtpsEmbeddedInfraService.java:
##########
@@ -19,13 +19,21 @@
import java.io.File;
+import org.apache.camel.spi.annotations.InfraService;
+import org.apache.camel.test.infra.ftp.services.FtpInfraService;
import org.apache.ftpserver.FtpServerFactory;
import org.apache.ftpserver.listener.ListenerFactory;
import org.apache.ftpserver.ssl.SslConfigurationFactory;
+@InfraService(service = FtpInfraService.class, serviceAlias = { "ftps" })
public class FtpsEmbeddedInfraService extends FtpEmbeddedInfraService {
Review Comment:
This is probably the only one I am a bit concerned about: by using an
embedded service, we'll end up bringing all the dependencies used for that
(this, for instance may expose us to a higher incidence of CVEs).
I don't think we must solve this now, but it's something I think we should
consider for the future versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
