timtebeek commented on code in PR #21:
URL:
https://github.com/apache/camel-upgrade-recipes/pull/21#discussion_r1925675284
##########
camel-spring-boot-upgrade-recipes/pom.xml:
##########
@@ -33,7 +33,8 @@
<description>Migration recipes (using openrewrite) for Camel Spring Boot
to make Maven migrations easier</description>
<properties>
- <spring-rewrite-version>5.24.1</spring-rewrite-version>
+ <!-- Update this with each spring-rewrite release -->
+ <spring-rewrite-version>6.0.1</spring-rewrite-version>
Review Comment:
The rewrite-recipe-bom:2.23.1 manages rewrites-spring:5.24.1.
https://repo1.maven.org/maven2/org/openrewrite/recipe/rewrite-recipe-bom/2.23.1/rewrite-recipe-bom-2.23.1.pom
OpenRewrite works best when versions released together are used together, to
avoid any missing references when there are internal changes.
What's the reason to override that version here? And are you aware of the
license change between 5.x and 6.x?
We recently made some accommodations to remove dependencies on MSAL modules
for Quarkus in
- https://github.com/quarkusio/quarkus-updates/pull/242
rewrite-spring is one of those MSAL modules, so can't itself be removed
without a loss of function. The managed older version is still Apache licensed,
so could be used until the way forward is clear.
```suggestion
<spring-rewrite-version>5.24.1</spring-rewrite-version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
