a-jubar opened a new pull request, #17265: URL: https://github.com/apache/camel/pull/17265
# Description I have added a new checkInitialReplayIdValidity method that gets executed once during the consumer startup if the provided ReplayPreset is CUSTOM. If the provided intial replay id is corrupt/invalid an exception is thrown and Camel shuts down. (The same behaviour as when a null initialReplayId is provided.) This workaround is just suggestion. It feels a bit hacky to me, but seems to be the best solution. I think the error handling of this commit https://github.com/apache/camel/commit/546a5016f05ce7bfc5a663bfd6ae6a0bf1d4d3e0 will not work like intended because the method resubscribeOnError() will always set the ReplayPreset to CUSTOM if replayId is not null. Sorry for being a bit late :) # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
