jamesnetherton commented on code in PR #7452:
URL: https://github.com/apache/camel-quarkus/pull/7452#discussion_r2154813179
##########
integration-test-groups/azure/azure-storage-datalake/src/main/java/org/apache/camel/quarkus/component/azure/storage/datalake/it/AzureStorageDatalakeResource.java:
##########
@@ -169,11 +178,66 @@ public String consumer(@PathParam("filesystem") String
filesystem,
10000, String.class);
}
+ @Path("/route/{route}/filesystem/{filesystem}")
+ @POST
+ @Produces(MediaType.APPLICATION_JSON)
+ public Object consumer(@PathParam("route") String routeName,
+ @PathParam("filesystem") String filesystem,
+ @QueryParam("useOutputStream") boolean useOutputStream,
+ Map<String, Object> headers) throws Exception {
+
+ ByteArrayOutputStream inMemoryStream = new ByteArrayOutputStream();
+
+ Map<String, Object> _headers = new HashMap();
+ if (headers != null) {
+ _headers.putAll(headers);
+
+ }
+ _headers.put("filesystemName", filesystem);
+ _headers.put("accountName", azureStorageAccountName.get());
+
+ System.out.println(_headers);
Review Comment:
Remove `println` or use a logger if the variable is worth logging.
##########
extensions/azure-storage-datalake/deployment/src/main/java/org/apache/camel/quarkus/component/azure/storage/datalake/deployment/AzureStorageDatalakeProcessor.java:
##########
@@ -54,10 +55,20 @@ ExtensionSslNativeSupportBuildItem
activateSslNativeSupport() {
ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem
combinedIndex) {
IndexView index = combinedIndex.getIndex();
- List<String> dtos = new LinkedList<>(index.getKnownClasses().stream()
+ LinkedHashSet<String> dtos = new
LinkedHashSet<>(index.getKnownClasses().stream()
.map(ci -> ci.name().toString())
.filter(n ->
n.startsWith("com.azure.storage.file.datalake.implementation.models"))
- .collect(Collectors.toList()));
+ .toList());
+
+
dtos.addAll(index.getAllKnownImplementations(HttpResponseException.class).stream()
+ .map(ci -> ci.name().toString())
+ .toList());
+
dtos.addAll(index.getAllKnownImplementations(JsonSerializable.class).stream()
+ .map(ci -> ci.name().toString())
+ .toList());
+
dtos.addAll(index.getAllKnownImplementations(XmlSerializable.class).stream()
+ .map(ci -> ci.name().toString())
+ .toList());
Review Comment:
`HttpResponseException` is a concrete class and not an interface. So the
Jandex lookup probably returns nothing. Reflection for that class is already
covered in `camel-quarkus-azure-support-core` anyway, so you can probably
remove the code from the datalake extension.
I think we should move reflection config for `JsonSerializable` and
`XmlSerializable ` into `camel-quarkus-azure-support-core` and clean up any
other extensions that try to set up reflection for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
