apupier commented on code in PR #18590: URL: https://github.com/apache/camel/pull/18590#discussion_r2200947087
########## dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/commands/DependencyUpdateTest.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands; + +import java.io.File; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.List; +import java.util.stream.Stream; + +import org.apache.camel.dsl.jbang.core.common.RuntimeType; +import org.apache.camel.dsl.jbang.core.common.StringPrinter; +import org.apache.camel.util.FileUtil; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; +import picocli.CommandLine; + +class DependencyUpdateTest extends CamelCommandBaseTest { + + private File workingDir; + + @BeforeEach + @Override + public void setup() throws Exception { + super.setup(); + Path base = Paths.get("target"); + workingDir = Files.createTempDirectory(base, "camel-dependency-update-tests").toFile(); + } + + @AfterEach + void end() { + // force removing, since deleteOnExit is not removing. + FileUtil.removeDir(workingDir); + } + + @ParameterizedTest + @MethodSource("runtimeProvider") + void shouldDependencyUpdate(RuntimeType rt) throws Exception { + prepareMavenProject(rt); + + checkNoUpdateOnFreshlyGeneratedproject(rt); + + //TODO: check content of pom.xml after a new component is provided + } + + private void checkNoUpdateOnFreshlyGeneratedproject(RuntimeType rt) throws Exception { + DependencyUpdate command = new DependencyUpdate(new CamelJBangMain().withPrinter(printer)); + CommandLine.populateCommand(command, + "--dir=" + workingDir, + "--runtime=%s".formatted(rt.runtime()), // This parameter to be removed when the runtime type will be auto-detected to compute dependencies + new File(workingDir, "pom.xml").getAbsolutePath()); + int exit = command.doCall(); + Assertions.assertEquals(0, exit, printer.getLines().toString()); + + List<String> lines = printer.getLines(); + Assertions.assertEquals(1, lines.size(), printer.getLines().toString()); + Assertions.assertEquals("No updates to pom.xml", lines.get(0)); + } + + private void prepareMavenProject(RuntimeType rt) throws Exception { + StringPrinter initCommandPrinter = new StringPrinter(); + Init initCommand = new Init(new CamelJBangMain().withPrinter(initCommandPrinter)); + String camelFilePath = new File(workingDir, "my.camel.yaml").getAbsolutePath(); + CommandLine.populateCommand(initCommand, camelFilePath); + Assertions.assertEquals(0, initCommand.doCall(), initCommandPrinter.getLines().toString()); + + StringPrinter exportCommandPrinter = new StringPrinter(); + Export exportCommand = new Export(new CamelJBangMain().withPrinter(exportCommandPrinter)); + CommandLine.populateCommand(exportCommand, + "--gav=examples:route:1.0.0", + "--dir=" + workingDir, + "--camel-version=4.13.0", Review Comment: Using a fixed version will allow to have a more stable test but the drawback is that it won't test with the latest version of exported projects. Not sure what's the best -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
