This is an automated email from the ASF dual-hosted git repository. pcongiusti pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit 1b05caa33c7a9b9608365e389b5465577211a637 Author: Pasquale Congiusti <[email protected]> AuthorDate: Sat Oct 18 17:51:43 2025 +0200 chore(e2e): kamelets missing no longer a failure In general we don't need to make a general error trait check, but instead specific for each trait failure we want to test. --- e2e/common/traits/errored_trait_test.go | 71 --------------------------------- 1 file changed, 71 deletions(-) diff --git a/e2e/common/traits/errored_trait_test.go b/e2e/common/traits/errored_trait_test.go deleted file mode 100644 index 61036d771..000000000 --- a/e2e/common/traits/errored_trait_test.go +++ /dev/null @@ -1,71 +0,0 @@ -//go:build integration -// +build integration - -// To enable compilation of this file in Goland, go to "Settings -> Go -> Vendoring & Build Tags -> Custom Tags" and add "integration" - -/* -Licensed to the Apache Software Foundation (ASF) under one or more -contributor license agreements. See the NOTICE file distributed with -this work for additional information regarding copyright ownership. -The ASF licenses this file to You under the Apache License, Version 2.0 -(the "License"); you may not use this file except in compliance with -the License. You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -package common - -import ( - "context" - "testing" - - . "github.com/onsi/gomega" - - corev1 "k8s.io/api/core/v1" - - . "github.com/apache/camel-k/v2/e2e/support" - v1 "github.com/apache/camel-k/v2/pkg/apis/camel/v1" -) - -func TestErroredTrait(t *testing.T) { - t.Parallel() - WithNewTestNamespace(t, func(ctx context.Context, g *WithT, ns string) { - t.Run("Integration trait should fail", func(t *testing.T) { - name := RandomizedSuffixName("it-errored") - g.Expect(KamelRun(t, ctx, ns, "files/Java.java", "--name", name, "-t", "kamelets.list=missing").Execute()).To(Succeed()) - g.Eventually(IntegrationPhase(t, ctx, ns, name), TestTimeoutShort).Should(Equal(v1.IntegrationPhaseError)) - g.Eventually(IntegrationConditionStatus(t, ctx, ns, name, v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionFalse)) - g.Eventually(IntegrationCondition(t, ctx, ns, name, v1.IntegrationConditionReady), TestTimeoutShort).Should(And( - WithTransform(IntegrationConditionReason, Equal(v1.IntegrationConditionInitializationFailedReason)), - WithTransform(IntegrationConditionMessage, HavePrefix("error during trait customization")), - )) - }) - - t.Run("Pipe trait should fail", func(t *testing.T) { - name := RandomizedSuffixName("kb-errored") - g.Expect(KamelBind(t, ctx, ns, "timer:foo", "log:bar", "--name", name, "-t", "kamelets.list=missing").Execute()).To(Succeed()) - // Pipe - g.Eventually(PipePhase(t, ctx, ns, name), TestTimeoutShort).Should(Equal(v1.PipePhaseError)) - g.Eventually(PipeConditionStatus(t, ctx, ns, name, v1.PipeConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionFalse)) - g.Eventually(PipeCondition(t, ctx, ns, name, v1.PipeConditionReady), TestTimeoutShort).Should( - WithTransform(PipeConditionMessage, And( - ContainSubstring("error during trait customization"), - ContainSubstring("[missing] not found"), - ))) - // Integration related - g.Eventually(IntegrationPhase(t, ctx, ns, name), TestTimeoutShort).Should(Equal(v1.IntegrationPhaseError)) - g.Eventually(IntegrationConditionStatus(t, ctx, ns, name, v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionFalse)) - g.Eventually(IntegrationCondition(t, ctx, ns, name, v1.IntegrationConditionReady), TestTimeoutShort).Should(And( - WithTransform(IntegrationConditionReason, Equal(v1.IntegrationConditionInitializationFailedReason)), - WithTransform(IntegrationConditionMessage, HavePrefix("error during trait customization")), - )) - }) - }) -}
