jamesnetherton commented on code in PR #429:
URL:
https://github.com/apache/camel-quarkus-examples/pull/429#discussion_r2513503490
##########
artemis-elasticsearch/src/test/java/org/acme/resource/ElasticSearchTestResource.java:
##########
@@ -22,22 +22,27 @@
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.commons.lang3.SystemUtils;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.elasticsearch.ElasticsearchContainer;
import org.testcontainers.utility.DockerImageName;
public class ElasticSearchTestResource implements
QuarkusTestResourceLifecycleManager {
private static final Logger LOG =
LoggerFactory.getLogger(ElasticSearchTestResource.class);
- private static final String IMAGE_NAME =
"mirror.gcr.io/elastic/elasticsearch:8.13.2";
+ private static String IMAGE_NAME =
"mirror.gcr.io/elastic/elasticsearch:8.13.2";
Review Comment:
As per the suggested change in the previous comment. We don't need a static
field for this. It can be a local variable defined within `start()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
