luigidemasi commented on code in PR #20100:
URL: https://github.com/apache/camel/pull/20100#discussion_r2580077470
##########
components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConfiguration.java:
##########
@@ -89,6 +89,17 @@ public class SmbConfiguration extends
GenericFileConfiguration {
+ " configurations, like timeouts")
private SmbConfig smbConfig;
+ @UriParam(label = "producer,advanced",
+ description = "Perform rename operations using a copy and delete
strategy. This option takes "
+ + "precedence over the copyAndDeleteOnRenameFail
parameter that will automatically fall back to the copy and delete "
+ + "strategy, but only after additional delays.",
+ defaultValue = "true")
+ private boolean renameUsingCopy = true;
Review Comment:
You're right, atomic is the better/faster mechanism. However, since
`copy-and-delete` has been the historical behavior, I defaulted to that to
guarantee backward compatibility. I set atomic as an opt-in to minimize risk
and don't introduce any breaking changes for existing setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
