This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new fc1103bbb29b chore(components): Sonar notes and minor compilation
warnings
fc1103bbb29b is described below
commit fc1103bbb29b23184f37f6c45398f4d87d7ea1bd
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Wed Dec 3 09:25:27 2025 +0100
chore(components): Sonar notes and minor compilation warnings
---
.../org/apache/camel/impl/debugger/DefaultBacklogDebugger.java | 4 ----
.../main/java/org/apache/camel/impl/debugger/DefaultDebugger.java | 3 +--
.../java/org/apache/camel/impl/engine/AbstractCamelContext.java | 2 +-
.../org/apache/camel/impl/engine/CamelPostProcessorHelper.java | 7 ++++---
.../camel/impl/engine/DefaultAsyncProcessorAwaitManager.java | 3 +--
.../apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java | 1 -
.../org/apache/camel/impl/engine/DefaultDevConsoleResolver.java | 2 +-
.../org/apache/camel/impl/engine/DefaultHealthCheckResolver.java | 3 +--
8 files changed, 9 insertions(+), 16 deletions(-)
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java
index fd20892131d3..2d41f81a70a4 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultBacklogDebugger.java
@@ -251,10 +251,6 @@ public final class DefaultBacklogDebugger extends
ServiceSupport implements Back
return !singleStepExchangeId.isEmpty();
}
- private boolean isSingleStepMode(String exchangeId) {
- return singleStepExchangeId.contains(exchangeId);
- }
-
@Override
public void attach() {
if (suspendMode) {
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultDebugger.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultDebugger.java
index 4fcdbefc793d..12c8cf72efaf 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultDebugger.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/debugger/DefaultDebugger.java
@@ -25,7 +25,6 @@ import java.util.Map;
import java.util.concurrent.CopyOnWriteArrayList;
import org.apache.camel.CamelContext;
-import org.apache.camel.CamelContextAware;
import org.apache.camel.Exchange;
import org.apache.camel.ExchangePropertyKey;
import org.apache.camel.MessageHistory;
@@ -48,7 +47,7 @@ import org.apache.camel.util.ObjectHelper;
/**
* The default implementation of the {@link Debugger}.
*/
-public class DefaultDebugger extends ServiceSupport implements Debugger,
CamelContextAware {
+public class DefaultDebugger extends ServiceSupport implements Debugger {
private final EventNotifier debugEventNotifier = new DebugEventNotifier();
private final List<BreakpointConditions> breakpoints = new
CopyOnWriteArrayList<>();
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
index 8bde8f3e1e9d..a321429a24d7 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
@@ -214,7 +214,7 @@ import static
org.apache.camel.spi.UnitOfWork.MDC_CAMEL_CONTEXT_ID;
* Represents the context used to configure routes and the policies to use.
*/
public abstract class AbstractCamelContext extends BaseService
- implements CamelContext, CatalogCamelContext, Suspendable {
+ implements CatalogCamelContext, Suspendable {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractCamelContext.class);
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelPostProcessorHelper.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelPostProcessorHelper.java
index 3767c93d1a1b..a927ac2f8017 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelPostProcessorHelper.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/CamelPostProcessorHelper.java
@@ -410,15 +410,16 @@ public class CamelPostProcessorHelper implements
CamelContextAware {
return getCamelContext().getTypeConverter();
}
// for templates then create a new instance and let camel
manage its lifecycle
+ // NOTE: the object will be closed by Camel lifecycle
Service answer = null;
if (getCamelContext() != null &&
type.isAssignableFrom(FluentProducerTemplate.class)) {
- answer = getCamelContext().createFluentProducerTemplate();
+ answer = getCamelContext().createFluentProducerTemplate();
// NOSONAR
}
if (getCamelContext() != null &&
type.isAssignableFrom(ProducerTemplate.class)) {
- answer = getCamelContext().createProducerTemplate();
+ answer = getCamelContext().createProducerTemplate(); //
NOSONAR
}
if (getCamelContext() != null &&
type.isAssignableFrom(ConsumerTemplate.class)) {
- answer = getCamelContext().createConsumerTemplate();
+ answer = getCamelContext().createConsumerTemplate(); //
NOSONAR
}
if (answer != null) {
// lets make camel context manage its lifecycle
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultAsyncProcessorAwaitManager.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultAsyncProcessorAwaitManager.java
index 5b69a6dc39e0..7b88fb0385ef 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultAsyncProcessorAwaitManager.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultAsyncProcessorAwaitManager.java
@@ -27,7 +27,6 @@ import java.util.concurrent.atomic.AtomicLong;
import org.apache.camel.AsyncProcessor;
import org.apache.camel.Exchange;
import org.apache.camel.RuntimeCamelException;
-import org.apache.camel.StaticService;
import org.apache.camel.spi.AsyncProcessorAwaitManager;
import org.apache.camel.spi.ExchangeFormatter;
import org.apache.camel.spi.ReactiveExecutor;
@@ -39,7 +38,7 @@ import org.apache.camel.util.StopWatch;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class DefaultAsyncProcessorAwaitManager extends ServiceSupport
implements AsyncProcessorAwaitManager, StaticService {
+public class DefaultAsyncProcessorAwaitManager extends ServiceSupport
implements AsyncProcessorAwaitManager {
private static final Logger LOG =
LoggerFactory.getLogger(DefaultAsyncProcessorAwaitManager.class);
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java
index 4f5b7052ba9c..521321afa711 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelBeanPostProcessor.java
@@ -497,7 +497,6 @@ public class DefaultCamelBeanPostProcessor implements
CamelBeanPostProcessor, Ca
if (parameterTypes.length != 1) {
LOG.warn("Ignoring badly annotated method for injection due to
incorrect number of parameters: {}", method);
} else {
- String propertyName =
org.apache.camel.util.ObjectHelper.getPropertyName(method);
Class<?> type = parameterTypes[0];
Type genericType = method.getGenericParameterTypes()[0];
Object value =
getPostProcessorHelper().getInjectionPropertyValue(type, genericType,
propertyValue,
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultDevConsoleResolver.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultDevConsoleResolver.java
index c5cfa01e824a..6ddfbc4dcae7 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultDevConsoleResolver.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultDevConsoleResolver.java
@@ -31,7 +31,7 @@ import org.apache.camel.support.service.ServiceSupport;
* Default dev console resolver that looks for dev consoles factories in
* <b>META-INF/services/org/apache/camel/dev-console/</b>.
*/
-public class DefaultDevConsoleResolver extends ServiceSupport implements
DevConsoleResolver, CamelContextAware {
+public class DefaultDevConsoleResolver extends ServiceSupport implements
DevConsoleResolver {
public static final String DEV_CONSOLE_RESOURCE_PATH =
"META-INF/services/org/apache/camel/dev-console/";
diff --git
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultHealthCheckResolver.java
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultHealthCheckResolver.java
index 18e92d84a03e..195b353600f6 100644
---
a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultHealthCheckResolver.java
+++
b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultHealthCheckResolver.java
@@ -17,7 +17,6 @@
package org.apache.camel.impl.engine;
import org.apache.camel.CamelContext;
-import org.apache.camel.CamelContextAware;
import org.apache.camel.NoFactoryAvailableException;
import org.apache.camel.health.HealthCheck;
import org.apache.camel.health.HealthCheckRepository;
@@ -28,7 +27,7 @@ import org.apache.camel.spi.FactoryFinder;
* Default health check resolver that looks for health checks factories in
* <b>META-INF/services/org/apache/camel/health-check/</b>.
*/
-public class DefaultHealthCheckResolver implements HealthCheckResolver,
CamelContextAware {
+public class DefaultHealthCheckResolver implements HealthCheckResolver {
public static final String HEALTH_CHECK_RESOURCE_PATH =
"META-INF/services/org/apache/camel/health-check/";
