This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 64a267b60db7 chore(test-infra): clarify intent of testing constants
64a267b60db7 is described below
commit 64a267b60db700d0b54e012aba186983ab87d3e7
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Thu Dec 4 09:51:18 2025 +0100
chore(test-infra): clarify intent of testing constants
---
.../java/org/apache/camel/maven/AbstractSalesforceMojo.java | 10 ++++------
.../camel/test/infra/artemis/services/ArtemisContainer.java | 3 ++-
.../services/ElasticSearchLocalContainerInfraService.java | 3 ++-
.../keycloak/services/KeycloakLocalContainerInfraService.java | 3 ++-
.../services/OpenSearchLocalContainerInfraService.java | 3 ++-
.../org/apache/camel/test/infra/smb/services/SmbContainer.java | 3 ++-
6 files changed, 14 insertions(+), 11 deletions(-)
diff --git
a/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/AbstractSalesforceMojo.java
b/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/AbstractSalesforceMojo.java
index 8d60b7a80c9f..575ff03ca865 100644
---
a/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/AbstractSalesforceMojo.java
+++
b/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/java/org/apache/camel/maven/AbstractSalesforceMojo.java
@@ -231,22 +231,20 @@ public abstract class AbstractSalesforceMojo extends
AbstractMojo {
if (clientSecret != null) {
if (password == null) {
throw new MojoExecutionException(
- generateRequiredErrorMessage("password",
"clientSecret"));
+ // NOTE: a text error message to clarify the problem
+ "Property 'password' must be provided when property
'clientSecret' was provided."); // NOSONAR
}
}
if (keystoreResource != null) {
if (keystorePassword == null) {
throw new MojoExecutionException(
- generateRequiredErrorMessage("keystorePassword",
"keystoreResource"));
+ // NOTE: a text error message to clarify the problem
+ "Property 'keystorePassword' must be provided when
property 'keystoreResource' was provided."); // NOSONAR
}
}
}
- private String generateRequiredErrorMessage(String parameter1, String
parameter2) {
- return String.format("Property: %s must be provided when property: %s
was provided.", parameter1, parameter2);
- }
-
private KeyStoreParameters generateKeyStoreParameters() {
if (keystoreResource == null) {
return null;
diff --git
a/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/ArtemisContainer.java
b/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/ArtemisContainer.java
index 624e45520e76..0e29e767b350 100644
---
a/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/ArtemisContainer.java
+++
b/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/ArtemisContainer.java
@@ -29,7 +29,8 @@ public class ArtemisContainer extends
GenericContainer<ArtemisContainer> impleme
private static final int DEFAULT_ADMIN_PORT = 8161;
private static final int DEFAULT_ACCEPTOR_PORT = 61616;
private static final String DEFAULT_USERNAME = "admin";
- private static final String DEFAULT_PASSWORD = "admin";
+ // NOTE: default value used for testing purposes only
+ private static final String DEFAULT_PASSWORD = "admin"; // NOSONAR
public ArtemisContainer() {
super(DockerImageName
diff --git
a/test-infra/camel-test-infra-elasticsearch/src/main/java/org/apache/camel/test/infra/elasticsearch/services/ElasticSearchLocalContainerInfraService.java
b/test-infra/camel-test-infra-elasticsearch/src/main/java/org/apache/camel/test/infra/elasticsearch/services/ElasticSearchLocalContainerInfraService.java
index d3e5fd2258e9..b3ea47c02c57 100644
---
a/test-infra/camel-test-infra-elasticsearch/src/main/java/org/apache/camel/test/infra/elasticsearch/services/ElasticSearchLocalContainerInfraService.java
+++
b/test-infra/camel-test-infra-elasticsearch/src/main/java/org/apache/camel/test/infra/elasticsearch/services/ElasticSearchLocalContainerInfraService.java
@@ -45,7 +45,8 @@ public class ElasticSearchLocalContainerInfraService
private static final Logger LOG =
LoggerFactory.getLogger(ElasticSearchLocalContainerInfraService.class);
private static final int ELASTIC_SEARCH_PORT = 9200;
private static final String USER_NAME = "elastic";
- private static final String PASSWORD = "s3cret";
+ // NOTE: default value used for testing purposes only.
+ private static final String PASSWORD = "s3cret"; // NOSONAR
private Path certPath;
private SSLContext sslContext;
private final ElasticsearchContainer container;
diff --git
a/test-infra/camel-test-infra-keycloak/src/main/java/org/apache/camel/test/infra/keycloak/services/KeycloakLocalContainerInfraService.java
b/test-infra/camel-test-infra-keycloak/src/main/java/org/apache/camel/test/infra/keycloak/services/KeycloakLocalContainerInfraService.java
index 039457a294f9..505ddcd92f07 100644
---
a/test-infra/camel-test-infra-keycloak/src/main/java/org/apache/camel/test/infra/keycloak/services/KeycloakLocalContainerInfraService.java
+++
b/test-infra/camel-test-infra-keycloak/src/main/java/org/apache/camel/test/infra/keycloak/services/KeycloakLocalContainerInfraService.java
@@ -40,7 +40,8 @@ public class KeycloakLocalContainerInfraService implements
KeycloakInfraService,
private static final String DEFAULT_KEYCLOAK_CONTAINER =
"quay.io/keycloak/keycloak:latest";
private static final int KEYCLOAK_PORT = 8080;
private static final String DEFAULT_ADMIN_USERNAME = "admin";
- private static final String DEFAULT_ADMIN_PASSWORD = "admin";
+ // NOTE: default value used only for testing purposes.
+ private static final String DEFAULT_ADMIN_PASSWORD = "admin"; // NOSONAR
private static final String DEFAULT_REALM = "master";
private final GenericContainer<?> container;
diff --git
a/test-infra/camel-test-infra-opensearch/src/main/java/org/apache/camel/test/infra/opensearch/services/OpenSearchLocalContainerInfraService.java
b/test-infra/camel-test-infra-opensearch/src/main/java/org/apache/camel/test/infra/opensearch/services/OpenSearchLocalContainerInfraService.java
index 1d6ed8441cfe..53053f14e2c7 100644
---
a/test-infra/camel-test-infra-opensearch/src/main/java/org/apache/camel/test/infra/opensearch/services/OpenSearchLocalContainerInfraService.java
+++
b/test-infra/camel-test-infra-opensearch/src/main/java/org/apache/camel/test/infra/opensearch/services/OpenSearchLocalContainerInfraService.java
@@ -34,7 +34,8 @@ public class OpenSearchLocalContainerInfraService implements
OpenSearchInfraServ
private static final Logger LOG =
LoggerFactory.getLogger(OpenSearchLocalContainerInfraService.class);
private static final int OPEN_SEARCH_PORT = 9200;
private static final String USER_NAME = "admin";
- private static final String PASSWORD = "admin";
+ // NOTE: default value used for testing purposes only.
+ private static final String PASSWORD = "admin"; // NOSONAR
private final OpensearchContainer container;
public OpenSearchLocalContainerInfraService() {
diff --git
a/test-infra/camel-test-infra-smb/src/main/java/org/apache/camel/test/infra/smb/services/SmbContainer.java
b/test-infra/camel-test-infra-smb/src/main/java/org/apache/camel/test/infra/smb/services/SmbContainer.java
index 1150c7c5a839..bab4257968a9 100644
---
a/test-infra/camel-test-infra-smb/src/main/java/org/apache/camel/test/infra/smb/services/SmbContainer.java
+++
b/test-infra/camel-test-infra-smb/src/main/java/org/apache/camel/test/infra/smb/services/SmbContainer.java
@@ -25,7 +25,8 @@ public class SmbContainer extends
GenericContainer<SmbContainer> {
public static final int SMB_PORT_DEFAULT = 445;
public static final String DEFAULT_USER = "camel";
- public static final String DEFAULT_PASSWORD = "camelTester123";
+ // NOTE: default value used for testing purposes only.
+ public static final String DEFAULT_PASSWORD = "camelTester123"; // NOSONAR
public SmbContainer(boolean fixedPort) {
super(new ImageFromDockerfile("localhost/samba:camel", false)
