bartoszpop opened a new pull request, #20341:
URL: https://github.com/apache/camel/pull/20341
Shared variables set with ComponentCustomizer for Freemarker are not
respected when using dynamic templates
# Description
I have a ComponentCustomizer which provides a custom Freemarker method:
```
@BindToRegistry(lazy=true)
public ComponentCustomizer freemarkerCustomizer(@BeanInject CacheService
cacheService) {
return new ComponentCustomizer() {
private final BeansWrapper beansWrapper =
new
BeansWrapperBuilder(freemarker.template.Configuration.DEFAULT_INCOMPATIBLE_IMPROVEMENTS).build();
@Override
public void configure(String name, Component component) {
try {
configure((FreemarkerComponent) component);
} catch (TemplateModelException e) {
throw new RuntimeException(e);
}
}
private void configure(FreemarkerComponent component) throws
TemplateModelException {
var configuration = component.getConfiguration();
configuration.setRecognizeStandardFileExtensions(true);
configuration.setRegisteredCustomOutputFormats(List.of(SafeJsonOutputFormat.INSTANCE));
configuration.setSharedVariable("customMethod", new
MyCustomMethod());
component.setConfiguration(configuration); // This is necessary
because FreemarkerComponent#getConfiguration returns a cloned object
}
@Override
public boolean isEnabled(String name, Component target) {
return target instanceof FreemarkerComponent;
}
};
}
```
When passing a template with the `CamelFreemarkerTemplate` header,
`FreemarkerEndpoint` creates a new `freemarker.template.Configuration` which
doesn't provide my customMethod.
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
