This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 5a11849472ab chore(tooling): maven package class check design comment
5a11849472ab is described below
commit 5a11849472ab840ebb5fee789863d71f4c8d0917
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Fri Dec 12 10:21:54 2025 +0100
chore(tooling): maven package class check design comment
---
.../apache/camel/maven/packaging/EndpointDslMojo.java | 4 ----
.../maven/packaging/EndpointSchemaGeneratorMojo.java | 3 ++-
.../camel/maven/packaging/PrepareCamelMainMojo.java | 18 ------------------
.../camel/maven/packaging/SchemaGeneratorMojo.java | 10 ++++++----
4 files changed, 8 insertions(+), 27 deletions(-)
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointDslMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointDslMojo.java
index d28bbd93bebc..91d566163569 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointDslMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointDslMojo.java
@@ -393,10 +393,6 @@ public class EndpointDslMojo extends AbstractGeneratorMojo
{
};
}
- private String getEndpointName(String type) {
- return getComponentNameFromType(type) + "EndpointBuilder";
- }
-
private boolean writeSourceIfChanged(String code, String filePath, String
fileName) throws MojoFailureException {
try {
if (getLog().isDebugEnabled()) {
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java
index 02fc1ba522c2..ce8bb2245999 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java
@@ -1699,7 +1699,8 @@ public class EndpointSchemaGeneratorMojo extends
AbstractGeneratorMojo {
return false;
}
- return
"groovy.lang.MetaClass".equals(method.getReturnType().getName());
+ // NOTE: we check the return type and the type may not be available
+ return
"groovy.lang.MetaClass".equals(method.getReturnType().getName()); // NOSONAR
}
protected void generatePropertyConfigurer(
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCamelMainMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCamelMainMojo.java
index 146730415070..efd9b7045912 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCamelMainMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCamelMainMojo.java
@@ -144,24 +144,6 @@ public class PrepareCamelMainMojo extends
AbstractGeneratorMojo {
return answer;
}
- private static String fromMainToType(String type) {
- if ("boolean".equals(type) || "java.lang.Boolean".equals(type)) {
- return "boolean";
- } else if ("int".equals(type) || "java.lang.Integer".equals(type)) {
- return "integer";
- } else if ("long".equals(type) || "java.lang.Long".equals(type)) {
- return "integer";
- } else if ("float".equals(type) || "java.lang.Float".equals(type)) {
- return "number";
- } else if ("double".equals(type) || "java.lang.Double".equals(type)) {
- return "number";
- } else if ("string".equals(type) || "java.lang.String".equals(type)) {
- return "string";
- } else {
- return "object";
- }
- }
-
private static Object asDefaultValue(String type, String defaultValue) {
if (defaultValue != null) {
if ("boolean".equals(type)) {
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SchemaGeneratorMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SchemaGeneratorMojo.java
index a06a20503ae4..a2b33e87fe3d 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SchemaGeneratorMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SchemaGeneratorMojo.java
@@ -468,7 +468,8 @@ public class SchemaGeneratorMojo extends
AbstractGeneratorMojo {
// special for eips which has outputs or requires an
expressions
XmlElementRef elementRef =
methodElement.getAnnotation(XmlElementRef.class);
if (elementRef != null) {
- if
("RouteDefinition".equals(classElement.getSimpleName())) {
+ // NOTE: class not available at compilation time.
+ if
("RouteDefinition".equals(classElement.getSimpleName())) { // NOSONAR
// special for route as we handle this specially
continue;
}
@@ -479,11 +480,12 @@ public class SchemaGeneratorMojo extends
AbstractGeneratorMojo {
// special when we process these nodes as they do not use JAXB
// annotations on fields, but on methods
- if
("OptionalIdentifiedDefinition".equals(classElement.getSimpleName())) {
+ // NOTE: classes not available at compilation time.
+ if
("OptionalIdentifiedDefinition".equals(classElement.getSimpleName())) { //
NOSONAR
processIdentified(classElement, eipOptions);
- } else if ("RouteDefinition".equals(classElement.getSimpleName()))
{
+ } else if ("RouteDefinition".equals(classElement.getSimpleName()))
{ // NOSONAR
processRoute(classElement, eipOptions);
- } else if ("TryDefinition".equals(classElement.getSimpleName())) {
+ } else if ("TryDefinition".equals(classElement.getSimpleName())) {
// NOSONAR
// special-case for doTry
processDoTry(classElement, eipOptions);
}
