squakez commented on code in PR #6416:
URL: https://github.com/apache/camel-k/pull/6416#discussion_r2619641804
##########
pkg/trait/jvm.go:
##########
@@ -368,3 +376,20 @@ func getLegacyCamelQuarkusDependenciesPaths() *sets.Set {
return s
}
+
+// configureCACert returns the JVM arguments for truststore configuration.
+func (t *jvmTrait) configureCaCert(e *Environment) ([]string, error) {
+ if t.CACert == "" {
+ return nil, nil
+ }
+
+ _, _, err := parseSecretRef(t.CACert)
+ if err != nil {
+ return nil, err
+ }
+
+ return []string{
+ "-Djavax.net.ssl.trustStore=" + t.getTrustStorePath(),
+ "-Djavax.net.ssl.trustStorePassword=" +
getTrustStorePassword(e.Integration.Name),
Review Comment:
This is introducing some potential security leak. I think we need to include
an additional secret configuration, (eg, `caCertPassword`) which the user must
include when setting the `caCert`. In this way we make it safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
