This is an automated email from the ASF dual-hosted git repository.
gfournier pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 3efe2b0e13ae chore(components): enhance random generation
3efe2b0e13ae is described below
commit 3efe2b0e13aef0afc866d3a345368edeb3c4a179
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Thu Jan 29 09:27:49 2026 +0100
chore(components): enhance random generation
Additionally clearning compilation warnings
---
.../camel/component/box/internal/BoxConnectionHelper.java | 4 ++--
.../apache/camel/component/box/AbstractBoxITSupport.java | 2 +-
.../org/apache/camel/component/box/BoxFilesManagerIT.java | 14 --------------
.../apache/camel/component/box/BoxFoldersManagerIT.java | 15 ---------------
.../src/test/resources/log4j2.properties | 6 +-----
5 files changed, 4 insertions(+), 37 deletions(-)
diff --git
a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java
b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java
index ccdede7e67cd..5c16b1fc6b70 100644
---
a/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java
+++
b/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java
@@ -53,6 +53,7 @@ import org.jsoup.select.Elements;
public final class BoxConnectionHelper {
private static final Pattern QUERY_PARAM_PATTERN =
Pattern.compile("&?([^=]+)=([^&]+)");
+ private static final SecureRandom SECURE_RANDOM = new SecureRandom();
private BoxConnectionHelper() {
// hide utility class constructor
@@ -78,7 +79,6 @@ public final class BoxConnectionHelper {
}
public static BoxAPIConnection
createStandardAuthenticatedConnection(BoxConfiguration configuration) {
-
// authorize application on user's behalf
try {
//prepare proxy parameter
@@ -98,7 +98,7 @@ public final class BoxConnectionHelper {
}
// generate anti-forgery token to prevent/detect CSRF attack
- final String csrfToken = String.valueOf(new
SecureRandom().nextLong());
+ final String csrfToken = String.valueOf(SECURE_RANDOM.nextLong());
final String authorizeUrl =
authorizationUrl(configuration.getClientId(), csrfToken);
diff --git
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/AbstractBoxITSupport.java
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/AbstractBoxITSupport.java
index 96544d247d38..d91385e09d67 100644
---
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/AbstractBoxITSupport.java
+++
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/AbstractBoxITSupport.java
@@ -44,7 +44,7 @@ public class AbstractBoxITSupport extends CamelTestSupport {
protected boolean jwtAuthentication;
protected Map<String, Object> options;
- private static boolean hasCredentials() throws IOException {
+ protected static boolean hasCredentials() throws IOException {
if (properties.isEmpty()) {
TestSupport.loadExternalProperties(properties,
AbstractBoxITSupport.class, TEST_OPTIONS_PROPERTIES);
}
diff --git
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFilesManagerIT.java
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFilesManagerIT.java
index 6439111d04fe..40bf748a80cc 100644
---
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFilesManagerIT.java
+++
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFilesManagerIT.java
@@ -18,7 +18,6 @@ package org.apache.camel.component.box;
import java.io.ByteArrayOutputStream;
import java.io.InputStream;
-import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
@@ -581,17 +580,4 @@ public class BoxFilesManagerIT extends
AbstractBoxITSupport {
testFile = rootFolder.uploadFile(stream,
CAMEL_TEST_FILE_NAME).getResource();
}
- private int sizeOfIterable(Iterable<?> it) {
- if (it instanceof Collection) {
- return ((Collection<?>) it).size();
- } else {
- int i = 0;
- for (@SuppressWarnings("unused")
- Object obj : it) {
- i++;
- }
- return i;
- }
-
- }
}
diff --git
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFoldersManagerIT.java
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFoldersManagerIT.java
index 498219090e5a..082fbb39091d 100644
---
a/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFoldersManagerIT.java
+++
b/components/camel-box/camel-box-component/src/test/java/org/apache/camel/component/box/BoxFoldersManagerIT.java
@@ -16,7 +16,6 @@
*/
package org.apache.camel.component.box;
-import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
@@ -308,18 +307,4 @@ public class BoxFoldersManagerIT extends
AbstractBoxITSupport {
testFolder = rootFolder.createFolder(CAMEL_TEST_FOLDER).getResource();
}
- private int sizeOfIterable(Iterable<?> it) {
- if (it instanceof Collection) {
- return ((Collection<?>) it).size();
- } else {
- int i = 0;
- for (@SuppressWarnings("unused")
- Object obj : it) {
- i++;
- }
- return i;
- }
-
- }
-
}
diff --git
a/components/camel-box/camel-box-component/src/test/resources/log4j2.properties
b/components/camel-box/camel-box-component/src/test/resources/log4j2.properties
index f2dfbcac0c82..05391c42a465 100644
---
a/components/camel-box/camel-box-component/src/test/resources/log4j2.properties
+++
b/components/camel-box/camel-box-component/src/test/resources/log4j2.properties
@@ -20,14 +20,10 @@ appender.file.name = file
appender.file.fileName = target/camel-box-component-test.log
appender.file.layout.type = PatternLayout
appender.file.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
-appender.out.type = Console
-appender.out.name = out
-appender.out.layout.type = PatternLayout
-appender.out.layout.pattern = %d [%-15.15t] %-5p %-30.30c{1} - %m%n
# uncomment the following line to turn on Camel debugging
#logger.camel.name = org.apache.camel
#logger.camel.level =DEBUG
rootLogger.level = INFO
-rootLogger.appenderRef.out.ref = out
+rootLogger.appenderRef.out.ref = file
