apupier opened a new pull request, #21234:
URL: https://github.com/apache/camel/pull/21234

   the body is provided in streaming mode with JDK 25 by default. Adapted the 
test in this sense.
   
   # Description
   
   I do not understand why with JDK 25, a streaming mode is used. The streaming 
mode seems to be something that could potentially be used as there was already 
the code in test where the streaming is specified. Maybe worth finding the 
exact explanation to be sure that adapting the test is enough and maybe provide 
a note in release note or if it is a bug in the component and need to fix it.
   Feedback very welcome if someone already worked on this component and 
remember what is the expected behavior
   
   
   
   Another note, a lot of unused code and duplicated code between test classes 
that would be nice to clean in another iteration.
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other 
small items do not require a JIRA issue. In this case your pull request should 
address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] 
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the 
appropriate JIRA issue.
   -->
   
   - [ ] I have run `mvn clean install -DskipTests` locally from root folder 
and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build 
auto-formats your code. This will also be verified as part of the checks and 
your PR may be rejected if if there are uncommited changes after running `mvn 
clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at 
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to