mcarlett commented on code in PR #21362:
URL: https://github.com/apache/camel/pull/21362#discussion_r2782661806
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/support/JBangTestSupport.java:
##########
@@ -138,7 +140,11 @@ protected String execute(final String command) {
}
protected String executeBackground(final String command) {
- return containerService.executeBackground(command);
+ return containerService.executeGenericCommand(MAIN_COMMAND + " " +
command + " --background");
Review Comment:
why you are implementing again what we already have in
`containerService.executeBackground()` ? is this a different behaviour?
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/support/JBangTestSupport.java:
##########
@@ -63,6 +63,8 @@ public abstract class JBangTestSupport {
private static final String DATA_FOLDER =
System.getProperty(CliProperties.DATA_FOLDER);
+ private static final String MAIN_COMMAND =
System.getProperty("cli.service.command");
Review Comment:
what do you think to implement a `getMainCommand()` method in the
`CliService` class so that we have just one place to retrieve the property? you
can use so `containerService.getMainCommand()` instead of `MAIN_COMMAND` in all
the places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
