Croway commented on code in PR #21388:
URL: https://github.com/apache/camel/pull/21388#discussion_r2792167952
##########
test-infra/camel-test-infra-zookeeper/src/main/java/org/apache/camel/test/infra/zookeeper/services/ZooKeeperLocalContainerInfraService.java:
##########
@@ -50,13 +50,10 @@ public
ZooKeeperLocalContainerInfraService(ZooKeeperContainer container) {
}
protected ZooKeeperContainer initContainer(String imageName) {
- int clientPort = ContainerEnvironmentUtil.isFixedPort(this.getClass())
- ? ZooKeeperContainer.CLIENT_PORT
- : -1;
if (imageName == null) {
- return new ZooKeeperContainer(ZooKeeperContainer.CONTAINER_NAME,
clientPort);
+ return new ZooKeeperContainer();
Review Comment:
ok, the changes to ZooKeeperContainer are ok, but the changes to
ZooKeeperLocalContainerInfraService should be reverted, and, in order to
support both camel test, and camel infra run with custom or default port
scenarios, the following diff can be applied.
[out.txt](https://github.com/user-attachments/files/25229721/out.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
