orpiske commented on code in PR #21496:
URL: https://github.com/apache/camel/pull/21496#discussion_r2813618316
##########
dsl/camel-jbang/camel-jbang-mcp/src/main/java/org/apache/camel/dsl/jbang/core/commands/mcp/CatalogTools.java:
##########
@@ -57,7 +57,10 @@ public ComponentListResult camel_catalog_components(
@ToolArg(description = "Filter by category label (e.g., cloud,
messaging, database, file)") String label,
@ToolArg(description = "Maximum number of results to return
(default: 50)") Integer limit,
@ToolArg(description = "Runtime type: main, spring-boot, or
quarkus (default: main)") String runtime,
- @ToolArg(description = "Specific Camel version to query (e.g.,
4.4.0). If not specified, uses the default catalog version.") String
camelVersion) {
+ @ToolArg(description = "Version to query. For main/spring-boot:
the Camel version (e.g., 4.17.0). "
Review Comment:
I'm thinking I'd be just a bit less ambiguous on the "main/spring-boot" and
would replace it with "Main or Spring Boot" (suggestion from Gemini to maximize
the description effectiveness).
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/version/VersionList.java:
##########
@@ -76,6 +76,8 @@ public class VersionList extends CamelCommand {
private static final String GIT_CAMEL_QUARKUS_URL
=
"https://raw.githubusercontent.com/apache/camel-website/main/content/releases/q/release-%s.md";;
+ private static final String QUARKUS_PLATFORM_URL =
"https://registry.quarkus.io/client/platforms";;
Review Comment:
Do you think it would be interesting to make this configurable via system
properties or environment variables, so we could point it to other registries
if necessary? (i.e.: for vendors productizing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
