mrutunjay-kinagi commented on PR #21538: URL: https://github.com/apache/camel/pull/21538#issuecomment-3925547459
Follow-up after checking CI run https://github.com/apache/camel/actions/runs/22173118628/job/64115618576?pr=21538 I pulled the `incremental-test-java-17.log` artifact and the hard failure was: - `AggregateParallelThreadPoolCallerRunsTest` (failed on all reruns, not flaky) Root cause was that I had changed non-transacted aggregate completion from `scheduleSync(task)` to `schedule(task)` unconditionally. That altered behavior for regular thread-pool executors (including caller-runs style paths) and regressed that test. I pushed a narrowed fix in `6457dde0b9a`: - keep `scheduleQueue(task)` for transacted exchanges - use `schedule(task)` only when `executorService instanceof SynchronousExecutorService` - otherwise keep existing `scheduleSync(task)` behavior This preserves existing thread-pool semantics while still preventing deep recursive completion with synchronous executors (the original stack-overflow case). Validation run: `./mvnw -pl core/camel-core -am -Dtest=AggregateParallelThreadPoolCallerRunsTest,SplitAggregateSynchronousExecutorStackOverflowIssueTest,SplitAggregateStackOverflowIssueTest,SplitAggregateParallelProcessingStackOverflowIssueTest test -DskipITs` Result: BUILD SUCCESS, Tests run: 4, Failures: 0, Errors: 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
