jamesnetherton commented on code in PR #8363:
URL: https://github.com/apache/camel-quarkus/pull/8363#discussion_r2873167715
##########
extensions/micrometer/runtime/src/main/java/org/apache/camel/quarkus/component/micrometer/CamelMicrometerConfig.java:
##########
@@ -105,6 +105,22 @@ public interface CamelMicrometerConfig {
*/
Optional<String> routePolicyExcludePattern();
+ /**
+ * Log metrics when application is shutting down. (default, `false`).
+ *
+ * @asciidoclet
+ */
+ @WithDefault("false")
+ boolean logMetricsOnShutdown();
+
+ /**
+ * List of metrics (comma separated) to log when application is shutting
down. You can use `*` character to log any
+ * metrics containing the wildcard, for example `camel.exchanges.*`
(default to all metrics available).
+ *
+ * @asciidoclet
+ */
+ Optional<String> logMetricsOnShutdownFilters();
Review Comment:
You can avoid the manual String split and rely on the builtin SmallRye
Config converters.
```suggestion
Optional<String[]> logMetricsOnShutdownFilters();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
