gnodet commented on PR #21899:
URL: https://github.com/apache/camel/pull/21899#issuecomment-4029994992
@squakez Good point, thanks for raising it. I dug into the numbers:
- **1508** total IT files across `components/`
- **280** have `@Disabled` or `ci.env.name` guards → will be skipped in CI
(all AI/LLM ITs that need real API keys or heavy containers fall here)
- **1228** without explicit guards, of which:
- **~114** directly reference
`@RegisterExtension`/`@Container`/`Testcontainers` (many more inherit it from
base classes like `FtpServerTestSupport`)
- Most use **embedded services** (embedded FTP, embedded Artemis,
localstack for AWS, etc.) that work fine on GitHub Actions
The ITs that require "too much network resources" (Ollama, LangChain4j chat,
kserve, etc.) are already guarded by `@DisabledIfSystemProperty(named =
"ci.env.name", matches = ".*")`, and GH Actions sets `ci.env.name=github.com`
via `MVND_OPTS`, so they'll remain skipped.
The ITs that **would** newly run are the ones using embedded services or
local testcontainers (JMS/Artemis, Kafka, MongoDB, FTP, AWS localstack, etc.).
These are designed to run in CI and many are already exercised by Jenkins.
Enabling them on GH Actions too would catch regressions earlier in the PR cycle.
That said, if there are specific ITs that are known to be flaky or
resource-heavy on GH Actions without proper `@Disabled` guards, we should fix
those independently. This change would actually help surface them.
Happy to revert if this causes widespread CI failures, but I think the
guards are already in place for the heavy tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
