squakez commented on PR #21898:
URL: https://github.com/apache/camel/pull/21898#issuecomment-4030561693
Thanks for the review.
> 1. Unrelated change — The PR removes the StaticService interface from
PropertiesComponent. This is orthogonal to tracing deprecation and should be a
separate commit or PR.
>
I agree but I think we need a bit of flexibility in a big project such
Camel. IMO, these simple and harmless changes are a way to clean the codebase
when we stumbled upon them. I can certainly remove from this PR, but I doubt I
will remind or have enough time to create a specific PR just for this.
> 2. Incomplete class-level deprecation — Only Tracer has @deprecated,
but public API types like SpanAdapter, SpanDecorator, ActiveSpanManager,
SpanKind, and TagConstants are not annotated. Users importing these types won't
get IDE warnings.
>
> 3. Duplicate runtime deprecation warnings — The base Tracer.init()
logs a warning, but subclass-specific methods also log warnings. Users will see
the message twice on startup.
>
Yeah, I will make sure to provide a more meaningful logging. Likely we
better have only the specific trace and skip the generic one.
> 4. Warning message typo — One message uses "Opentelemetry" instead of
"OpenTelemetry" (capital T).
>
> 5. Missing @SuppressWarnings("deprecation") — 3 core test files that
use the deprecated tracing API will trigger compiler warnings without
suppression annotations.
I'll work soon to a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
