gnodet commented on PR #21994: URL: https://github.com/apache/camel/pull/21994#issuecomment-4072881262
Thanks for the detailed response, those are fair points. I agree the main source of confusion was the "RAG" naming — renaming to something like `MilvusHelper` (or similar) would make the intent much clearer and address most of my concerns. The rest of the design choices (string properties for YAML binding, separate INSERT/UPSERT beans, no extra validation) are consistent with how the Qdrant helpers work, so that makes sense. A `@param` Javadoc note on the setters documenting the expected format (e.g., `field1=var1,field2=var2`) would be a nice addition too, but not a blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
