gnodet commented on code in PR #22084:
URL: https://github.com/apache/camel/pull/22084#discussion_r2954582758
##########
components/camel-spring-parent/camel-spring-ai/camel-spring-ai-chat/src/test/java/org/apache/camel/component/springai/chat/SpringAiChatParameterOverrideIT.java:
##########
@@ -67,8 +67,7 @@ public void testTopPOverrideViaHeader() {
String response = exchange.getMessage().getBody(String.class);
assertThat(response).isNotNull();
- // With low top_p, should get more deterministic responses
- assertThat(response.toLowerCase()).containsAnyOf("blue", "above",
"high");
+ assertThat(response).isNotEmpty();
Review Comment:
Good point. Improved the assertion to verify the response has multiple words
and check the token count header is set, which validates the topP parameter
override actually worked. Simply checking `isNotEmpty()` was indeed too weak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
