gnodet commented on PR #22086: URL: https://github.com/apache/camel/pull/22086#issuecomment-4088370501
@jamesnetherton You're right that the container infra provides `granite-embedding:30m` by default (via `container.properties`). The issue only manifests with the **remote** infra (`-Dollama.instance.type=remote`), which reads from `System.getProperty(OllamaProperties.EMBEDDING_MODEL)` with no fallback default. The JIRA reporter was running: ``` mvn verify -Dollama.endpoint=http://localhost:11434/ -Dollama.model=granite4:3b -Dollama.instance.type=remote ``` ...without specifying `-Dollama.embedding.model=...`, so `embeddingModelName()` returned `null`. I agree that `Assumptions.assumeTrue` is not ideal here. I'll rework the PR to: 1. Remove the assumption guard 2. Keep the exception assertions (those are genuinely useful regardless — the `ClassCastException` was very confusing) 3. Fail fast in `setupResources` if the embedding model is null, as you suggested Alternatively, we could also fix `OllamaRemoteInfraService` to fall back to `container.properties` defaults (like the container infra does), but that's a separate concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
