gnodet commented on code in PR #22281:
URL: https://github.com/apache/camel/pull/22281#discussion_r2994926044
##########
tooling/camel-tooling-model/src/main/java/org/apache/camel/tooling/model/BaseOptionModel.java:
##########
@@ -344,7 +344,7 @@ public String getShortDefaultValue(int watermark) {
}
public String getShortName(int watermark) {
- String text = Strings.wrapCamelCaseWords(name, watermark, "{zwsp}");
+ String text = Strings.wrapCamelCaseWords(name, watermark, "");
// ensure the option name starts with lower-case
return Character.toLowerCase(text.charAt(0)) + text.substring(1);
Review Comment:
With `""` as separator, `wrapCamelCaseWords` splits camelCase into words and
joins them back unchanged, and the uppercase/lowercase operations cancel each
other out — making this method a no-op.
```suggestion
return name;
```
The method itself (and the `watermark` parameter) could be removed entirely
in a follow-up PR, replacing `row.getShortName(30)` with `row.name` in the two
MVEL templates (`main-options.mvel` and `jbang-options.mvel`).
_Claude Code on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
