gnodet commented on PR #22295: URL: https://github.com/apache/camel/pull/22295#issuecomment-4142247397
_Claude Code on behalf of Guillaume Nodet_ Have you considered whether the handler is actually needed? I checked the Netty 4.2.10 bytecode and `SslUtils.handleHandshakeFailure()` unconditionally calls `ctx.close()` after firing the `SslHandshakeCompletionEvent`. The `exceptionCaught()` methods in `ClientChannelHandler`/`ServerChannelHandler` also already close the channel on SSL errors. The TODO comments were left over from the Netty 3→4 migration (CAMEL-6555, 2014) and were misleading — the behavior they asked for already exists natively in Netty 4.x. A simpler fix might be to just remove the TODOs and commented-out code, optionally replacing them with a short comment like: ```java // Note: Netty 4.x SslHandler automatically closes the channel on handshake failure // (unlike Netty 3.x which required setCloseOnSSLException(true)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
