gnodet commented on code in PR #22305:
URL: https://github.com/apache/camel/pull/22305#discussion_r3005060495


##########
core/camel-core-model/src/generated/resources/META-INF/services/org/apache/camel/model.properties:
##########
@@ -173,6 +185,12 @@ sample
 script
 security
 securityDefinitions
+serviceCall
+serviceCallConfiguration
+serviceChooserConfiguration
+serviceDiscoveryConfiguration
+serviceExpression
+serviceFilterConfiguration
 setBody
 setExchangePattern

Review Comment:
   **Blocking**: These 6 entries (plus 14 others spread across this file: 
`blacklistServiceFilter`, `cachingServiceDiscovery`, 
`combinedServiceDiscovery`, `combinedServiceFilter`, `consulServiceDiscovery`, 
`customServiceFilter`, `defaultLoadBalancer`, `dnsServiceDiscovery`, 
`healthyServiceFilter`, `kubernetesServiceDiscovery`, 
`loadBalancerConfiguration`, `passThroughServiceFilter`, 
`staticServiceDiscovery`, `zookeeperServiceDiscovery`) were intentionally 
removed in c216fd94aead (CAMEL-22290, CAMEL-22289: _"Remove deprecated 
camel-cloud and ServiceCall"_).
   
   The corresponding Java model classes no longer exist in the codebase — they 
were part of `org.apache.camel.model.cloud.*` which was deleted in that commit. 
Re-adding these entries to `model.properties` is a regression.
   
   This likely happened because `mvn install -pl core/camel-core-model` 
regenerated this file from a local Maven repository that still contained stale 
metadata. To fix: revert all 20 additions to this file (the diff should show 0 
additions / 0 deletions for this file).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to