gnodet commented on PR #22344: URL: https://github.com/apache/camel/pull/22344#issuecomment-4159939473
_Claude Code on behalf of Guillaume Nodet_ One more observation on the sensitive data detection approach — the regex is purely **tag-name-based**, matching any XML element whose name contains keywords like "password", "token", "secret", etc. This has some limitations worth considering: **False positives** — non-secret values in elements that happen to contain a keyword: - `<password-policy>strict</password-policy>` — config value, not a secret - `<token-refresh-interval>300</token-refresh-interval>` — numeric setting - `<secret-sharing-enabled>true</secret-sharing-enabled>` — boolean flag **False negatives** — actual secrets in elements with non-obvious names: - `<db.connection>jdbc:mysql://user:s3cret@host/db</db.connection>` — credential embedded in a URL - `<my.credential>actual-secret</my.credential>` — note: "credential" (singular) is not in the keyword list, only "credentials" (plural) The heuristic is reasonable as a best-effort safety net, but worth documenting these limitations — especially since false positives could mask legitimate configuration values that the migration analysis might need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
