This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 65b7cdaba39bcc657dfb90aae8f7f21538a3c73d Author: Otavio Rodolfo Piske <[email protected]> AuthorDate: Sat Mar 28 13:36:53 2026 +0000 (chores): fix SonarCloud S5993 in camel-support Change public constructors of abstract classes to protected. Claude Code on behalf of Otavio R. Piske Co-Authored-By: Claude Sonnet 4.6 <[email protected]> --- .../apache/camel/component/ResourceEndpoint.java | 4 ++-- .../apache/camel/support/DefaultAsyncProducer.java | 2 +- .../org/apache/camel/support/DefaultComponent.java | 4 ++-- .../org/apache/camel/support/DefaultProducer.java | 2 +- .../apache/camel/support/EventNotifierSupport.java | 2 +- .../support/HeaderFilterStrategyComponent.java | 4 ++-- .../camel/support/HeaderSelectorProducer.java | 22 +++++++++++----------- .../apache/camel/support/HealthCheckComponent.java | 4 ++-- .../camel/support/PollingConsumerSupport.java | 2 +- .../camel/support/PooledObjectFactorySupport.java | 4 ++-- .../support/ScheduledBatchPollingConsumer.java | 4 ++-- .../camel/support/ScheduledPollConsumer.java | 4 ++-- .../camel/support/SimpleEventNotifierSupport.java | 2 +- .../apache/camel/support/cache/ServicePool.java | 2 +- .../support/component/AbstractApiComponent.java | 6 +++--- .../support/component/AbstractApiConsumer.java | 2 +- .../support/component/AbstractApiEndpoint.java | 6 +++--- .../support/component/AbstractApiProducer.java | 2 +- .../camel/support/component/ApiMethodParser.java | 2 +- .../camel/support/console/AbstractDevConsole.java | 2 +- .../support/scan/BasePackageScanResolver.java | 2 +- .../apache/camel/support/task/AbstractTask.java | 2 +- 22 files changed, 43 insertions(+), 43 deletions(-) diff --git a/core/camel-support/src/main/java/org/apache/camel/component/ResourceEndpoint.java b/core/camel-support/src/main/java/org/apache/camel/component/ResourceEndpoint.java index a1a59c461f40..d6112b45e9e3 100644 --- a/core/camel-support/src/main/java/org/apache/camel/component/ResourceEndpoint.java +++ b/core/camel-support/src/main/java/org/apache/camel/component/ResourceEndpoint.java @@ -61,10 +61,10 @@ public abstract class ResourceEndpoint extends ProcessorEndpoint implements Mana private final Lock lock = new ReentrantLock(); - public ResourceEndpoint() { + protected ResourceEndpoint() { } - public ResourceEndpoint(String endpointUri, Component component, String resourceUri) { + protected ResourceEndpoint(String endpointUri, Component component, String resourceUri) { super(endpointUri, component); this.resourceUri = resourceUri; } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/DefaultAsyncProducer.java b/core/camel-support/src/main/java/org/apache/camel/support/DefaultAsyncProducer.java index 24372acc9788..f374053976f3 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/DefaultAsyncProducer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/DefaultAsyncProducer.java @@ -29,7 +29,7 @@ import org.apache.camel.spi.AsyncProcessorAwaitManager; */ public abstract class DefaultAsyncProducer extends DefaultProducer implements AsyncProducer { - public DefaultAsyncProducer(Endpoint endpoint) { + protected DefaultAsyncProducer(Endpoint endpoint) { super(endpoint); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/DefaultComponent.java b/core/camel-support/src/main/java/org/apache/camel/support/DefaultComponent.java index 5e70d60749e5..ad07db3178fa 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/DefaultComponent.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/DefaultComponent.java @@ -86,10 +86,10 @@ public abstract class DefaultComponent extends ServiceSupport implements Compone + " then creating and starting the producer may take a little time and prolong the total processing time of the processing.") private boolean lazyStartProducer; - public DefaultComponent() { + protected DefaultComponent() { } - public DefaultComponent(CamelContext context) { + protected DefaultComponent(CamelContext context) { this.camelContext = context; } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/DefaultProducer.java b/core/camel-support/src/main/java/org/apache/camel/support/DefaultProducer.java index dc4dc48275a0..cefd52139224 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/DefaultProducer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/DefaultProducer.java @@ -34,7 +34,7 @@ public abstract class DefaultProducer extends ServiceSupport implements Producer private transient String producerToString; private final Endpoint endpoint; - public DefaultProducer(Endpoint endpoint) { + protected DefaultProducer(Endpoint endpoint) { this.endpoint = endpoint; } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/EventNotifierSupport.java b/core/camel-support/src/main/java/org/apache/camel/support/EventNotifierSupport.java index 2010b6dca965..0bb36c69c04d 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/EventNotifierSupport.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/EventNotifierSupport.java @@ -34,7 +34,7 @@ public abstract class EventNotifierSupport extends SimpleEventNotifierSupport im private CamelContext camelContext; - public EventNotifierSupport() { + protected EventNotifierSupport() { setupIgnore(false); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/HeaderFilterStrategyComponent.java b/core/camel-support/src/main/java/org/apache/camel/support/HeaderFilterStrategyComponent.java index 4e10fe283e8a..d6dc9e77446a 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/HeaderFilterStrategyComponent.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/HeaderFilterStrategyComponent.java @@ -31,10 +31,10 @@ public abstract class HeaderFilterStrategyComponent extends DefaultComponent imp description = "To use a custom org.apache.camel.spi.HeaderFilterStrategy to filter header to and from Camel message.") private HeaderFilterStrategy headerFilterStrategy; - public HeaderFilterStrategyComponent() { + protected HeaderFilterStrategyComponent() { } - public HeaderFilterStrategyComponent(CamelContext context) { + protected HeaderFilterStrategyComponent(CamelContext context) { super(context); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/HeaderSelectorProducer.java b/core/camel-support/src/main/java/org/apache/camel/support/HeaderSelectorProducer.java index 6ac0edcd79d2..5cb617324178 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/HeaderSelectorProducer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/HeaderSelectorProducer.java @@ -51,41 +51,41 @@ public abstract class HeaderSelectorProducer extends DefaultAsyncProducer implem private InvokeOnHeaderStrategy strategy; private InvokeOnHeaderStrategy parentStrategy; - public HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier) { + protected HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier) { this(endpoint, headerSupplier, () -> null, null); } - public HeaderSelectorProducer(Endpoint endpoint, String header) { + protected HeaderSelectorProducer(Endpoint endpoint, String header) { this(endpoint, () -> header, () -> null, null); } - public HeaderSelectorProducer(Endpoint endpoint, String header, Object target) { + protected HeaderSelectorProducer(Endpoint endpoint, String header, Object target) { this(endpoint, () -> header, () -> null, target); } - public HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, Object target) { + protected HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, Object target) { this(endpoint, headerSupplier, () -> null, target); } - public HeaderSelectorProducer(Endpoint endpoint, String header, String defaultHeaderValue) { + protected HeaderSelectorProducer(Endpoint endpoint, String header, String defaultHeaderValue) { this(endpoint, () -> header, () -> defaultHeaderValue, null); } - public HeaderSelectorProducer(Endpoint endpoint, String header, Supplier<String> defaultHeaderValueSupplier) { + protected HeaderSelectorProducer(Endpoint endpoint, String header, Supplier<String> defaultHeaderValueSupplier) { this(endpoint, () -> header, defaultHeaderValueSupplier, null); } - public HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, - Supplier<String> defaultHeaderValueSupplier) { + protected HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, + Supplier<String> defaultHeaderValueSupplier) { this(endpoint, headerSupplier, defaultHeaderValueSupplier, null); } - public HeaderSelectorProducer(Endpoint endpoint, String header, String defaultHeaderValue, Object target) { + protected HeaderSelectorProducer(Endpoint endpoint, String header, String defaultHeaderValue, Object target) { this(endpoint, () -> header, () -> defaultHeaderValue, target); } - public HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, - Supplier<String> defaultHeaderValueSupplier, Object target) { + protected HeaderSelectorProducer(Endpoint endpoint, Supplier<String> headerSupplier, + Supplier<String> defaultHeaderValueSupplier, Object target) { super(endpoint); this.headerSupplier = ObjectHelper.notNull(headerSupplier, "headerSupplier"); diff --git a/core/camel-support/src/main/java/org/apache/camel/support/HealthCheckComponent.java b/core/camel-support/src/main/java/org/apache/camel/support/HealthCheckComponent.java index de0107f75a23..925648794d7e 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/HealthCheckComponent.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/HealthCheckComponent.java @@ -34,10 +34,10 @@ public abstract class HealthCheckComponent extends DefaultComponent { + " You can turn on producer checks globally by setting camel.health.producersEnabled=true.") private boolean healthCheckProducerEnabled = true; - public HealthCheckComponent() { + protected HealthCheckComponent() { } - public HealthCheckComponent(CamelContext context) { + protected HealthCheckComponent(CamelContext context) { super(context); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/PollingConsumerSupport.java b/core/camel-support/src/main/java/org/apache/camel/support/PollingConsumerSupport.java index 61f3b9572761..957f2b6921c9 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/PollingConsumerSupport.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/PollingConsumerSupport.java @@ -31,7 +31,7 @@ public abstract class PollingConsumerSupport extends ServiceSupport implements P private final Endpoint endpoint; private ExceptionHandler exceptionHandler; - public PollingConsumerSupport(Endpoint endpoint) { + protected PollingConsumerSupport(Endpoint endpoint) { this.endpoint = endpoint; this.exceptionHandler = new LoggingExceptionHandler(endpoint.getCamelContext(), getClass()); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/PooledObjectFactorySupport.java b/core/camel-support/src/main/java/org/apache/camel/support/PooledObjectFactorySupport.java index e8db72385194..ed4feb28addc 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/PooledObjectFactorySupport.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/PooledObjectFactorySupport.java @@ -36,11 +36,11 @@ public abstract class PooledObjectFactorySupport<T> extends ServiceSupport imple protected int capacity = 100; protected boolean statisticsEnabled; - public PooledObjectFactorySupport() { + protected PooledObjectFactorySupport() { this.source = null; } - public PooledObjectFactorySupport(Object source) { + protected PooledObjectFactorySupport(Object source) { this.source = source; } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledBatchPollingConsumer.java b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledBatchPollingConsumer.java index fa03ebbdb7c7..d99244b6fab5 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledBatchPollingConsumer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledBatchPollingConsumer.java @@ -39,11 +39,11 @@ public abstract class ScheduledBatchPollingConsumer extends ScheduledPollConsume protected volatile int pendingExchanges; protected int maxMessagesPerPoll; - public ScheduledBatchPollingConsumer(Endpoint endpoint, Processor processor) { + protected ScheduledBatchPollingConsumer(Endpoint endpoint, Processor processor) { super(endpoint, processor); } - public ScheduledBatchPollingConsumer(Endpoint endpoint, Processor processor, ScheduledExecutorService executor) { + protected ScheduledBatchPollingConsumer(Endpoint endpoint, Processor processor, ScheduledExecutorService executor) { super(endpoint, processor, executor); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java index c9cfdcb1258a..016c1994c98e 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java @@ -82,11 +82,11 @@ public abstract class ScheduledPollConsumer extends DefaultConsumer private volatile boolean firstPollDone; private volatile boolean forceReady; - public ScheduledPollConsumer(Endpoint endpoint, Processor processor) { + protected ScheduledPollConsumer(Endpoint endpoint, Processor processor) { super(endpoint, processor); } - public ScheduledPollConsumer(Endpoint endpoint, Processor processor, ScheduledExecutorService scheduledExecutorService) { + protected ScheduledPollConsumer(Endpoint endpoint, Processor processor, ScheduledExecutorService scheduledExecutorService) { super(endpoint, processor); // we have been given an existing thread pool, so we should not manage its lifecycle // so we should keep shutdownExecutor as false diff --git a/core/camel-support/src/main/java/org/apache/camel/support/SimpleEventNotifierSupport.java b/core/camel-support/src/main/java/org/apache/camel/support/SimpleEventNotifierSupport.java index 63cdbc88e339..848c593155fd 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/SimpleEventNotifierSupport.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/SimpleEventNotifierSupport.java @@ -46,7 +46,7 @@ public abstract class SimpleEventNotifierSupport extends ServiceSupport implemen boolean ignoreExchangeSentEvents; boolean ignoreStepEvents; - public SimpleEventNotifierSupport() { + protected SimpleEventNotifierSupport() { setupIgnore(true); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java index 91a072a273e9..7254a0f0dac5 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java @@ -69,7 +69,7 @@ abstract class ServicePool<S extends Service> extends ServiceSupport implements void cleanUp(); } - public ServicePool(ThrowingFunction<Endpoint, S, Exception> creator, Function<S, Endpoint> getEndpoint, int capacity) { + protected ServicePool(ThrowingFunction<Endpoint, S, Exception> creator, Function<S, Endpoint> getEndpoint, int capacity) { this.creator = creator; this.getEndpoint = getEndpoint; this.capacity = capacity; diff --git a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiComponent.java b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiComponent.java index b1da635c2b71..191c72eee6ad 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiComponent.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiComponent.java @@ -51,7 +51,7 @@ public abstract class AbstractApiComponent<E extends Enum<E> & ApiName, T, S ext * @param collection The collection of API methods */ @Deprecated(since = "4.1.0") - public AbstractApiComponent(Class<? extends Endpoint> endpointClass, Class<E> apiNameClass, S collection) { + protected AbstractApiComponent(Class<? extends Endpoint> endpointClass, Class<E> apiNameClass, S collection) { this(apiNameClass, collection); } @@ -67,8 +67,8 @@ public abstract class AbstractApiComponent<E extends Enum<E> & ApiName, T, S ext * @param collection The collection of API methods */ @Deprecated(since = "4.2.0") - public AbstractApiComponent(CamelContext context, Class<? extends Endpoint> endpointClass, Class<E> apiNameClass, - S collection) { + protected AbstractApiComponent(CamelContext context, Class<? extends Endpoint> endpointClass, Class<E> apiNameClass, + S collection) { this(context, apiNameClass, collection); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiConsumer.java b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiConsumer.java index 0837e4346bfa..f9348809e8c2 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiConsumer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiConsumer.java @@ -41,7 +41,7 @@ public abstract class AbstractApiConsumer<E extends Enum<E> & ApiName, T> // split Array or Collection API method results into multiple Exchanges private boolean splitResult = true; - public AbstractApiConsumer(AbstractApiEndpoint<E, T> endpoint, Processor processor) { + protected AbstractApiConsumer(AbstractApiEndpoint<E, T> endpoint, Processor processor) { super(endpoint, processor); this.endpoint = endpoint; diff --git a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java index d8bab90c22b6..1444459b433b 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiEndpoint.java @@ -82,9 +82,9 @@ public abstract class AbstractApiEndpoint<E extends ApiName, T> private Set<String> configurationPropertyNames; private Map<String, Object> configurationProperties; - public AbstractApiEndpoint(String endpointUri, Component component, - E apiName, String methodName, ApiMethodHelper<? extends ApiMethod> methodHelper, - T endpointConfiguration) { + protected AbstractApiEndpoint(String endpointUri, Component component, + E apiName, String methodName, ApiMethodHelper<? extends ApiMethod> methodHelper, + T endpointConfiguration) { super(endpointUri, component); this.apiName = apiName; diff --git a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiProducer.java b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiProducer.java index c575e1292da0..e59d0a9c5e0a 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiProducer.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiProducer.java @@ -49,7 +49,7 @@ public abstract class AbstractApiProducer<E extends Enum<E> & ApiName, T> // logger private final transient Logger log = LoggerFactory.getLogger(getClass()); - public AbstractApiProducer(AbstractApiEndpoint<E, T> endpoint, ApiMethodPropertiesHelper<T> propertiesHelper) { + protected AbstractApiProducer(AbstractApiEndpoint<E, T> endpoint, ApiMethodPropertiesHelper<T> propertiesHelper) { super(endpoint); this.propertiesHelper = propertiesHelper; this.endpoint = endpoint; diff --git a/core/camel-support/src/main/java/org/apache/camel/support/component/ApiMethodParser.java b/core/camel-support/src/main/java/org/apache/camel/support/component/ApiMethodParser.java index 9874ea0a893f..05cf9e413ae4 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/component/ApiMethodParser.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/component/ApiMethodParser.java @@ -64,7 +64,7 @@ public abstract class ApiMethodParser<T> { private final Map<String, String> descriptions = new HashMap<>(); private ClassLoader classLoader = ApiMethodParser.class.getClassLoader(); - public ApiMethodParser(Class<T> proxyType) { + protected ApiMethodParser(Class<T> proxyType) { this.proxyType = proxyType; } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/console/AbstractDevConsole.java b/core/camel-support/src/main/java/org/apache/camel/support/console/AbstractDevConsole.java index c664c61d3b04..9d775429d20e 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/console/AbstractDevConsole.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/console/AbstractDevConsole.java @@ -37,7 +37,7 @@ public abstract class AbstractDevConsole extends ServiceSupport implements DevCo private final String displayName; private final String description; - public AbstractDevConsole(String group, String id, String displayName, String description) { + protected AbstractDevConsole(String group, String id, String displayName, String description) { this.lock = new ReentrantLock(); this.group = group; this.id = id; diff --git a/core/camel-support/src/main/java/org/apache/camel/support/scan/BasePackageScanResolver.java b/core/camel-support/src/main/java/org/apache/camel/support/scan/BasePackageScanResolver.java index 538914ba8a3f..d198ed37df2b 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/scan/BasePackageScanResolver.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/scan/BasePackageScanResolver.java @@ -42,7 +42,7 @@ public abstract class BasePackageScanResolver extends ServiceSupport implements private final Set<ClassLoader> classLoaders = new LinkedHashSet<>(); private CamelContext camelContext; - public BasePackageScanResolver() { + protected BasePackageScanResolver() { initialize(); } diff --git a/core/camel-support/src/main/java/org/apache/camel/support/task/AbstractTask.java b/core/camel-support/src/main/java/org/apache/camel/support/task/AbstractTask.java index f613ccc9ed62..2ea8f365c8a9 100644 --- a/core/camel-support/src/main/java/org/apache/camel/support/task/AbstractTask.java +++ b/core/camel-support/src/main/java/org/apache/camel/support/task/AbstractTask.java @@ -27,7 +27,7 @@ abstract class AbstractTask implements Task { long nextAttemptTime; Throwable cause; - public AbstractTask(String name) { + protected AbstractTask(String name) { this.name = name; this.status = Status.Active; this.firstAttemptTime = NEVER;
