thomas-gantenbein-tga commented on PR #22311:
URL: https://github.com/apache/camel/pull/22311#issuecomment-4217703840

   Thanks, @davsclaus and @essobedo. I tested my reproducer with the change 
from 
https://github.com/apache/camel/pull/22500https://github.com/apache/camel/pull/22500
 and yes, that change fixes, as expected, the CPU problem that became evident 
after 100'000 files had been processed.
   
   I guess you are aware of this, but I'll write it anyway: That change fixes 
the CPU problem, but it still lets the `lastChanges` queue grow to 100'001 
items, of which 100'000 are paths to files that have already been processed and 
are not "inProgress", i.e. not part of the `delegate` HashMap anymore. Only 
then it's cleaned up. Then it grows again to 100'001 items, then it's cleaned 
up again and so on. Maybe that's only me, I just don't find that overly pretty.
   
   Thanks for the fix, anyway. And, of course, feel free to close this PR 
unmerged if you think the LRU fix is good enough and the change here is not 
worth the lines it adds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to