CAMEL-10020: Fixed CS
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/0409cf08 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/0409cf08 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/0409cf08 Branch: refs/heads/master Commit: 0409cf089d2143a61bc1d478077d51ba45f0737d Parents: 466e03c Author: Claus Ibsen <davscl...@apache.org> Authored: Fri Jul 1 08:55:25 2016 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Fri Jul 1 08:55:25 2016 +0200 ---------------------------------------------------------------------- .../component/kafka/KafkaProducerFullTest.java | 50 +++++++++----------- .../component/kafka/KafkaProducerTest.java | 8 ++-- 2 files changed, 26 insertions(+), 32 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/0409cf08/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerFullTest.java ---------------------------------------------------------------------- diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerFullTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerFullTest.java index f1189d5..88f0177 100644 --- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerFullTest.java +++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerFullTest.java @@ -31,7 +31,6 @@ import org.apache.camel.EndpointInject; import org.apache.camel.Exchange; import org.apache.camel.Produce; import org.apache.camel.ProducerTemplate; -import org.apache.camel.RoutesBuilder; import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.mock.MockEndpoint; import org.apache.kafka.clients.consumer.ConsumerRecord; @@ -130,19 +129,16 @@ public class KafkaProducerFullTest extends BaseEmbeddedKafkaTest { assertTrue("Not all messages were published to the kafka topics. Not received: " + messagesLatch.getCount(), allMessagesReceived); - List<Exchange> exchangeList= mockEndpoint.getExchanges(); - assertEquals("Fifteen Exchanges are expected",exchangeList.size(),15); + List<Exchange> exchangeList = mockEndpoint.getExchanges(); + assertEquals("Fifteen Exchanges are expected", exchangeList.size(), 15); for (Exchange exchange : exchangeList) { - List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>)(exchange.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); - assertEquals("One RecordMetadata is expected.",recordMetaData1.size(),1); - assertTrue("Offset is positive",recordMetaData1.get(0).offset() >= 0); - assertTrue("Topic Name start with 'test'",recordMetaData1.get(0).topic().startsWith("test")); - + List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>) (exchange.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); + assertEquals("One RecordMetadata is expected.", recordMetaData1.size(), 1); + assertTrue("Offset is positive", recordMetaData1.get(0).offset() >= 0); + assertTrue("Topic Name start with 'test'", recordMetaData1.get(0).topic().startsWith("test")); } - } - @Test public void producedStringCollectionMessageIsReceivedByKafka() throws InterruptedException, IOException { int messageInTopic = 10; @@ -167,21 +163,21 @@ public class KafkaProducerFullTest extends BaseEmbeddedKafkaTest { boolean allMessagesReceived = messagesLatch.await(200, TimeUnit.MILLISECONDS); assertTrue("Not all messages were published to the kafka topics. Not received: " + messagesLatch.getCount(), allMessagesReceived); - List<Exchange> exchangeList= mockEndpoint.getExchanges(); - assertEquals("Two Exchanges are expected",exchangeList.size(),2); + List<Exchange> exchangeList = mockEndpoint.getExchanges(); + assertEquals("Two Exchanges are expected", exchangeList.size(), 2); Exchange e1 = exchangeList.get(0); - List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>)(e1.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); - assertEquals("Ten RecordMetadata is expected.",recordMetaData1.size(),10); + List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>) (e1.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); + assertEquals("Ten RecordMetadata is expected.", recordMetaData1.size(), 10); for (RecordMetadata recordMeta : recordMetaData1) { - assertTrue("Offset is positive",recordMeta.offset() >= 0); - assertTrue("Topic Name start with 'test'",recordMeta.topic().startsWith("test")); + assertTrue("Offset is positive", recordMeta.offset() >= 0); + assertTrue("Topic Name start with 'test'", recordMeta.topic().startsWith("test")); } Exchange e2 = exchangeList.get(1); - List<RecordMetadata> recordMetaData2 = (List<RecordMetadata>)(e2.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); - assertEquals("Five RecordMetadata is expected.",recordMetaData2.size(),5); + List<RecordMetadata> recordMetaData2 = (List<RecordMetadata>) (e2.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); + assertEquals("Five RecordMetadata is expected.", recordMetaData2.size(), 5); for (RecordMetadata recordMeta : recordMetaData2) { - assertTrue("Offset is positive",recordMeta.offset() >= 0); - assertTrue("Topic Name start with 'test'",recordMeta.topic().startsWith("test")); + assertTrue("Offset is positive", recordMeta.offset() >= 0); + assertTrue("Topic Name start with 'test'", recordMeta.topic().startsWith("test")); } } @@ -207,16 +203,14 @@ public class KafkaProducerFullTest extends BaseEmbeddedKafkaTest { assertTrue("Not all messages were published to the kafka topics. Not received: " + messagesLatch.getCount(), allMessagesReceived); - List<Exchange> exchangeList= mockEndpoint.getExchanges(); - assertEquals("Fifteen Exchanges are expected",exchangeList.size(),15); + List<Exchange> exchangeList = mockEndpoint.getExchanges(); + assertEquals("Fifteen Exchanges are expected", exchangeList.size(), 15); for (Exchange exchange : exchangeList) { - List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>)(exchange.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); - assertEquals("One RecordMetadata is expected.",recordMetaData1.size(),1); - assertTrue("Offset is positive",recordMetaData1.get(0).offset() >= 0); - assertTrue("Topic Name start with 'test'",recordMetaData1.get(0).topic().startsWith("test")); - + List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>) (exchange.getIn().getHeader(KafkaConstants.KAFKA_RECORDMETA)); + assertEquals("One RecordMetadata is expected.", recordMetaData1.size(), 1); + assertTrue("Offset is positive", recordMetaData1.get(0).offset() >= 0); + assertTrue("Topic Name start with 'test'", recordMetaData1.get(0).topic().startsWith("test")); } - } private void createKafkaMessageConsumer(KafkaConsumer<String, String> consumerConn, http://git-wip-us.apache.org/repos/asf/camel/blob/0409cf08/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java ---------------------------------------------------------------------- diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java index c10266e..449349f 100644 --- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java +++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaProducerTest.java @@ -114,7 +114,7 @@ public class KafkaProducerTest { ArgumentCaptor<Callback> callBackCaptor = ArgumentCaptor.forClass(Callback.class); Mockito.verify(producer.getKafkaProducer()).send(Matchers.any(ProducerRecord.class), callBackCaptor.capture()); Callback kafkaCallback = callBackCaptor.getValue(); - kafkaCallback.onCompletion(new RecordMetadata(null, 1, 1),null); + kafkaCallback.onCompletion(new RecordMetadata(null, 1, 1), null); assertRecordMetadataExists(); } @@ -138,7 +138,7 @@ public class KafkaProducerTest { Mockito.verify(exchange).setException(Matchers.isA(ApiException.class)); Mockito.verify(callback).done(Matchers.eq(true)); Callback kafkaCallback = callBackCaptor.getValue(); - kafkaCallback.onCompletion(new RecordMetadata(null, 1, 1),null); + kafkaCallback.onCompletion(new RecordMetadata(null, 1, 1), null); assertRecordMetadataExists(); } @@ -273,9 +273,9 @@ public class KafkaProducerTest { } private void assertRecordMetadataExists() { - List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>)(in.getHeader(KafkaConstants.KAFKA_RECORDMETA)); + List<RecordMetadata> recordMetaData1 = (List<RecordMetadata>) in.getHeader(KafkaConstants.KAFKA_RECORDMETA); assertTrue(recordMetaData1 != null); - assertEquals("Expected one recordMetaData",recordMetaData1.size(),1); + assertEquals("Expected one recordMetaData", recordMetaData1.size(), 1); assertTrue(recordMetaData1.get(0) != null); } }