apupier commented on code in PR #22981:
URL: https://github.com/apache/camel/pull/22981#discussion_r3193743685
##########
components/camel-as2/camel-as2-api/src/test/java/org/apache/camel/component/as2/api/AS2MessageTestBase.java:
##########
@@ -86,14 +84,13 @@ public class AS2MessageTestBase {
protected static final String METHOD = "POST";
protected static final String TARGET_HOST = "localhost";
- @RegisterExtension
- protected static AvailablePortFinder.Port TARGET_PORT =
AvailablePortFinder.find();
+ protected static int TARGET_PORT;
Review Comment:
given that it is no more a final attribute:
"Rename this field "RECIPIENT_DELIVERY_ADDRESS" to match the regular
expression '^[a-z][a-zA-Z0-9]*$'."
##########
components/camel-as2/camel-as2-api/src/test/java/org/apache/camel/component/as2/api/AS2MessageTestBase.java:
##########
@@ -86,14 +84,13 @@ public class AS2MessageTestBase {
protected static final String METHOD = "POST";
protected static final String TARGET_HOST = "localhost";
- @RegisterExtension
- protected static AvailablePortFinder.Port TARGET_PORT =
AvailablePortFinder.find();
+ protected static int TARGET_PORT;
protected static final Duration HTTP_SOCKET_TIMEOUT =
Duration.ofSeconds(5);
protected static final Duration HTTP_CONNECTION_TIMEOUT =
Duration.ofSeconds(5);
protected static final Integer HTTP_CONNECTION_POOL_SIZE = 5;
protected static final Duration HTTP_CONNECTION_POOL_TTL =
Duration.ofMinutes(15);
protected static final Certificate[] VALIDATE_SIGNING_CERTIFICATE_CHAIN =
null;
- protected static final String RECIPIENT_DELIVERY_ADDRESS =
"http://localhost:"; + TARGET_PORT.getPort() + "/handle-receipts";
+ protected static String RECIPIENT_DELIVERY_ADDRESS;
Review Comment:
given that it is no more a final attribute:
"Rename this field "RECIPIENT_DELIVERY_ADDRESS" to match the regular
expression '^[a-z][a-zA-Z0-9]*$'."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
