davsclaus commented on code in PR #23021:
URL: https://github.com/apache/camel/pull/23021#discussion_r3206861834
##########
core/camel-api/src/main/java/org/apache/camel/spi/LifecycleStrategy.java:
##########
@@ -199,8 +200,8 @@ default void onServiceRemove(CamelContext context, Service
service, Route route,
* @param threadPoolProfileId id of the thread pool profile, if used for
creating this thread pool (can be null)
*/
void onThreadPoolAdd(
- CamelContext camelContext, ThreadPoolExecutor threadPool, String
id,
- String sourceId, String routeId, String threadPoolProfileId);
+ CamelContext camelContext, ThreadPoolExecutor threadPool,
@Nullable String id,
Review Comment:
we should likely enforce that some of these are not null as creating a
thread pool we should have id / source id to identify it.
##########
core/camel-api/src/main/java/org/apache/camel/spi/LifecycleStrategy.java:
##########
@@ -222,8 +223,8 @@ void onThreadPoolAdd(
* @param threadPoolProfileId id of the thread pool profile, if used for
creating this thread pool (can be null)
*/
default void onThreadPoolAdd(
- CamelContext camelContext, ExecutorService executorService, String
id,
- String sourceId, String routeId, String threadPoolProfileId) {
+ CamelContext camelContext, ExecutorService executorService,
@Nullable String id,
Review Comment:
we should likely enforce that some of these are not null as creating a
thread pool we should have id / source id to identify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
