oscerd commented on code in PR #23081: URL: https://github.com/apache/camel/pull/23081#discussion_r3207549239
########## components/camel-telemetry/src/main/java/org/apache/camel/telemetry/decorators/AwsEksSpanDecorator.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.telemetry.Span; + +public class AwsEksSpanDecorator extends AbstractSpanDecorator { + + static final String EKS_OPERATION = "operation"; + static final String EKS_CLUSTER_NAME = "clusterName"; + static final String EKS_ROLE_ARN = "roleArn"; Review Comment: Done in 8525094 — `AwsEksSpanDecorator` no longer emits the `roleArn` tag, and the test was updated accordingly. Even though the EKS cluster role ARN is a request input rather than a response value, surfacing IAM principal ARNs to observability backends is an unnecessary identity disclosure. This brings EKS in line with the same minimization principle that drove the IAM `userName`, KMS `keyId` and CloudTrail `username` drops in earlier batches. EKS now keeps `operation` and `clusterName`. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
