oscerd commented on PR #23125: URL: https://github.com/apache/camel/pull/23125#issuecomment-4428322835
Pushed 7c1479fa90e addressing all of @gnodet's and @davsclaus's review feedback: **Blocking items** - **Stale generated files** (@davsclaus / @gnodet "Blocking 1"): regenerated and committed `catalog/.../docling.json`, `DoclingComponentBuilderFactory.java`, and `DoclingEndpointBuilderFactory.java`. Verified that a clean `mvn clean install -DskipTests` from the repo root now produces no further uncommitted regen artifacts. - **`Thread.sleep` in tests** (@gnodet "Blocking 2"): replaced with the suggested Awaitility `during/atMost` pattern. **Non-blocking suggestions (both applied)** - **Test comment vs actual behavior** (@gnodet #3): this turned out to be more than a comment error — with the 60s minimum, the cleanup-interval was actually 60s for the 2s test TTL, so the existing `atMost(5, SECONDS)` could never fire. Lowered the cleanup-interval floor from 60s → 1s (cleanup is cheap when the map is empty, so the lower minimum is safe and makes short TTLs actually meaningful), corrected the test comment, bumped `atMost` to 8s for headroom, and added `isUseAdviceWith() = true` so the test-configured TTL is in effect by the time `doStart` runs. - **Logging level** (@gnodet #4): lowered `doStart`/`doStop`/cleanup-summary lines from `LOG.info` to `LOG.debug`. **Drive-by** While running the test suite I also found that the pre-existing `DoclingAsyncConversionTest` wasn't updated when the PR changed the map's value type to `AsyncTaskEntry` — it was still inserting raw `CompletableFuture` and producing `ClassCastException` on 3 tests. Updated the test to wrap in `AsyncTaskEntry`. **Verification** - camel-docling: 49 tests, 0 failures, 0 errors (was 3 ClassCastException errors on `DoclingAsyncConversionTest` + flaky `DoclingAsyncTaskTtlTest`). - Full reactor `mvn clean install -DskipTests` from root: SUCCESS in 8:42. - `git status` clean after the full reactor build — no further regen artifacts. cc @Croway @davsclaus @gnodet for re-review when convenient. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
